mfd: Fix davinci memory leak
Error handling code following a kmalloc should free the allocated data. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; statement S; expression E; identifier f,f1,l; position p1,p2; expression *ptr != NULL; @@ x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S <... when != x when != if (...) { <+...x...+> } ( x->f1 = E | (x->f1 == NULL || ...) | f(...,x->f1,...) ) ...> ( return \(0\|<+...x...+>\|ptr\); | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This commit is contained in:
parent
8af5fe3bc5
commit
e2bde78713
|
@ -94,7 +94,8 @@ static int __init davinci_vc_probe(struct platform_device *pdev)
|
||||||
res = platform_get_resource(pdev, IORESOURCE_DMA, 0);
|
res = platform_get_resource(pdev, IORESOURCE_DMA, 0);
|
||||||
if (!res) {
|
if (!res) {
|
||||||
dev_err(&pdev->dev, "no DMA resource\n");
|
dev_err(&pdev->dev, "no DMA resource\n");
|
||||||
return -ENXIO;
|
ret = -ENXIO;
|
||||||
|
goto fail4;
|
||||||
}
|
}
|
||||||
|
|
||||||
davinci_vc->davinci_vcif.dma_tx_channel = res->start;
|
davinci_vc->davinci_vcif.dma_tx_channel = res->start;
|
||||||
|
@ -104,7 +105,8 @@ static int __init davinci_vc_probe(struct platform_device *pdev)
|
||||||
res = platform_get_resource(pdev, IORESOURCE_DMA, 1);
|
res = platform_get_resource(pdev, IORESOURCE_DMA, 1);
|
||||||
if (!res) {
|
if (!res) {
|
||||||
dev_err(&pdev->dev, "no DMA resource\n");
|
dev_err(&pdev->dev, "no DMA resource\n");
|
||||||
return -ENXIO;
|
ret = -ENXIO;
|
||||||
|
goto fail4;
|
||||||
}
|
}
|
||||||
|
|
||||||
davinci_vc->davinci_vcif.dma_rx_channel = res->start;
|
davinci_vc->davinci_vcif.dma_rx_channel = res->start;
|
||||||
|
|
Loading…
Reference in New Issue