OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

staging: wlang-ng: avoid new typedef: hfa384x_metacmd_t 

This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs

It applies for typedef hfa384x_metacmd_t

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Sergio Paracuellos 2016-09-28 20:20:18 +02:00 committed by Greg Kroah-Hartman
parent 3df38936a7
commit e2f503c40d
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/wlan-ng/hfa384x.h
View File

@ -1206,7 +1206,7 @@ struct hfa384x_usbctlxq {
struct list_head reapable; struct list_head reapable;
}; };
typedef struct hfa484x_metacmd { struct hfa384x_metacmd {
u16 cmd; u16 cmd;
u16 parm0; u16 parm0;
@ -1214,7 +1214,7 @@ typedef struct hfa484x_metacmd {
u16 parm2; u16 parm2;
struct hfa384x_cmdresult result; struct hfa384x_cmdresult result;
} hfa384x_metacmd_t; };
#define MAX_GRP_ADDR 32 #define MAX_GRP_ADDR 32
#define WLAN_COMMENT_MAX 80 /* Max. length of user comment string. */ #define WLAN_COMMENT_MAX 80 /* Max. length of user comment string. */

18
drivers/staging/wlan-ng/hfa384x_usb.c
View File

@ -224,7 +224,7 @@ usbctlx_get_rridresult(const struct hfa384x_usb_rridresp *rridresp,
static int static int
hfa384x_docmd(hfa384x_t *hw, hfa384x_docmd(hfa384x_t *hw,
enum cmd_mode mode, enum cmd_mode mode,
hfa384x_metacmd_t *cmd, struct hfa384x_metacmd *cmd,
ctlx_cmdcb_t cmdcb, ctlx_usercb_t usercb, void *usercb_data); ctlx_cmdcb_t cmdcb, ctlx_usercb_t usercb, void *usercb_data);
static int static int
@ -812,14 +812,14 @@ static void hfa384x_cb_status(hfa384x_t *hw, const struct hfa384x_usbctlx *ctlx)
} }
} }
static inline int hfa384x_docmd_wait(hfa384x_t *hw, hfa384x_metacmd_t *cmd) static inline int hfa384x_docmd_wait(hfa384x_t *hw, struct hfa384x_metacmd *cmd)
{ {
return hfa384x_docmd(hw, DOWAIT, cmd, NULL, NULL, NULL); return hfa384x_docmd(hw, DOWAIT, cmd, NULL, NULL, NULL);
} }
static inline int static inline int
hfa384x_docmd_async(hfa384x_t *hw, hfa384x_docmd_async(hfa384x_t *hw,
hfa384x_metacmd_t *cmd, struct hfa384x_metacmd *cmd,
ctlx_cmdcb_t cmdcb, ctlx_usercb_t usercb, void *usercb_data) ctlx_cmdcb_t cmdcb, ctlx_usercb_t usercb, void *usercb_data)
{ {
return hfa384x_docmd(hw, DOASYNC, cmd, cmdcb, usercb, usercb_data); return hfa384x_docmd(hw, DOASYNC, cmd, cmdcb, usercb, usercb_data);
@ -927,7 +927,7 @@ int hfa384x_cmd_initialize(hfa384x_t *hw)
{ {
int result = 0; int result = 0;
int i; int i;
hfa384x_metacmd_t cmd; struct hfa384x_metacmd cmd;
cmd.cmd = HFA384x_CMDCODE_INIT; cmd.cmd = HFA384x_CMDCODE_INIT;
cmd.parm0 = 0; cmd.parm0 = 0;
@ -971,7 +971,7 @@ int hfa384x_cmd_initialize(hfa384x_t *hw)
----------------------------------------------------------------*/ ----------------------------------------------------------------*/
int hfa384x_cmd_disable(hfa384x_t *hw, u16 macport) int hfa384x_cmd_disable(hfa384x_t *hw, u16 macport)
{ {
hfa384x_metacmd_t cmd; struct hfa384x_metacmd cmd;
cmd.cmd = HFA384x_CMD_CMDCODE_SET(HFA384x_CMDCODE_DISABLE) | cmd.cmd = HFA384x_CMD_CMDCODE_SET(HFA384x_CMDCODE_DISABLE) |
HFA384x_CMD_MACPORT_SET(macport); HFA384x_CMD_MACPORT_SET(macport);
@ -1004,7 +1004,7 @@ int hfa384x_cmd_disable(hfa384x_t *hw, u16 macport)
----------------------------------------------------------------*/ ----------------------------------------------------------------*/
int hfa384x_cmd_enable(hfa384x_t *hw, u16 macport) int hfa384x_cmd_enable(hfa384x_t *hw, u16 macport)
{ {
hfa384x_metacmd_t cmd; struct hfa384x_metacmd cmd;
cmd.cmd = HFA384x_CMD_CMDCODE_SET(HFA384x_CMDCODE_ENABLE) | cmd.cmd = HFA384x_CMD_CMDCODE_SET(HFA384x_CMDCODE_ENABLE) |
HFA384x_CMD_MACPORT_SET(macport); HFA384x_CMD_MACPORT_SET(macport);
@ -1046,7 +1046,7 @@ int hfa384x_cmd_enable(hfa384x_t *hw, u16 macport)
----------------------------------------------------------------*/ ----------------------------------------------------------------*/
int hfa384x_cmd_monitor(hfa384x_t *hw, u16 enable) int hfa384x_cmd_monitor(hfa384x_t *hw, u16 enable)
{ {
hfa384x_metacmd_t cmd; struct hfa384x_metacmd cmd;
cmd.cmd = HFA384x_CMD_CMDCODE_SET(HFA384x_CMDCODE_MONITOR) | cmd.cmd = HFA384x_CMD_CMDCODE_SET(HFA384x_CMDCODE_MONITOR) |
HFA384x_CMD_AINFO_SET(enable); HFA384x_CMD_AINFO_SET(enable);
@ -1098,7 +1098,7 @@ int hfa384x_cmd_monitor(hfa384x_t *hw, u16 enable)
int hfa384x_cmd_download(hfa384x_t *hw, u16 mode, u16 lowaddr, int hfa384x_cmd_download(hfa384x_t *hw, u16 mode, u16 lowaddr,
u16 highaddr, u16 codelen) u16 highaddr, u16 codelen)
{ {
hfa384x_metacmd_t cmd; struct hfa384x_metacmd cmd;
pr_debug("mode=%d, lowaddr=0x%04x, highaddr=0x%04x, codelen=%d\n", pr_debug("mode=%d, lowaddr=0x%04x, highaddr=0x%04x, codelen=%d\n",
mode, lowaddr, highaddr, codelen); mode, lowaddr, highaddr, codelen);
@ -1291,7 +1291,7 @@ cleanup:
static int static int
hfa384x_docmd(hfa384x_t *hw, hfa384x_docmd(hfa384x_t *hw,
enum cmd_mode mode, enum cmd_mode mode,
hfa384x_metacmd_t *cmd, struct hfa384x_metacmd *cmd,
ctlx_cmdcb_t cmdcb, ctlx_usercb_t usercb, void *usercb_data) ctlx_cmdcb_t cmdcb, ctlx_usercb_t usercb, void *usercb_data)
{ {
int result; int result;