OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

serial: mfd: fix bug in serial_hsu_remove() 

Medfield HSU driver deal with 4 pci devices(3 uart ports + 1 dma controller),
so in pci remove func, we need handle them differently

Signed-off-by: Feng Tang <feng.tang@intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Feng Tang 2010-09-06 13:41:02 +01:00 committed by Greg Kroah-Hartman
parent 476f771cb9
commit e3671ac429
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/serial/mfd.c
View File

@ -1423,7 +1423,6 @@ static void hsu_global_init(void)
}
phsu = hsu;
hsu_debugfs_init(hsu);
return;
@ -1435,18 +1434,20 @@ err_free_region:
static void serial_hsu_remove(struct pci_dev *pdev)
{
struct hsu_port *hsu;
int i;
void *priv = pci_get_drvdata(pdev);
struct uart_hsu_port *up;
hsu = pci_get_drvdata(pdev);
if (!hsu)
if (!priv)
return;
for (i = 0; i < 3; i++)
uart_remove_one_port(&serial_hsu_reg, &hsu->port[i].port);
/* For port 0/1/2, priv is the address of uart_hsu_port */
if (pdev->device != 0x081E) {
up = priv;
uart_remove_one_port(&serial_hsu_reg, &up->port);
}
pci_set_drvdata(pdev, NULL);
free_irq(hsu->irq, hsu);
free_irq(pdev->irq, priv);
pci_disable_device(pdev);
}