OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

PCI: rpaphp: Use pcibios_remove_pci_devices() symmetrically 

At first blush, the disable_slot() routine does not look
at all like its symmetric with the enable_slot() routine;
as it seems to call a very different set of routines.
However, this is easily fixed: pcibios_remove_pci_devices()
does the right thing.

Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
Cc: John Rose <johnrose@austin.ibm.com>
Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Linas Vepstas 2007-04-13 15:34:23 -07:00 committed by Greg Kroah-Hartman
parent da65944be2
commit e70ea2634a
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/pci/hotplug/rpaphp_core.c
View File

@ -424,18 +424,12 @@ static int enable_slot(struct hotplug_slot *hotplug_slot)
return retval;
}
static int __disable_slot(struct slot *slot)
static inline int __disable_slot(struct slot *slot)
{
struct pci_dev *dev, *tmp;
if (slot->state == NOT_CONFIGURED)
return -EINVAL;
list_for_each_entry_safe(dev, tmp, &slot->bus->devices, bus_list) {
eeh_remove_bus_device(dev);
pci_remove_bus_device(dev);
}
pcibios_remove_pci_devices(slot->bus);
slot->state = NOT_CONFIGURED;
return 0;
}