OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

udlfb: Fix invalid return codes in edid sysfs entry store function 

Return a negative errno instead of zero in the write function of
the sysfs entry in case of error.
Also add a check on the return value of dlfb_setup_modes().

Signed-off-by: Olivier Sobrie <olivier@sobrie.be>
Acked-by: Bernie Thompson <bernie@plugable.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
This commit is contained in:
Olivier Sobrie 2012-02-29 08:06:40 +01:00 committed by Florian Tobias Schandinat
parent 33ad39121d
commit e71ff6f265
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/video/udlfb.c
View File

@ -1432,19 +1432,22 @@ static ssize_t edid_store(
struct device *fbdev = container_of(kobj, struct device, kobj);
struct fb_info *fb_info = dev_get_drvdata(fbdev);
struct dlfb_data *dev = fb_info->par;
int ret;
/* We only support write of entire EDID at once, no offset*/
if ((src_size != EDID_LENGTH) || (src_off != 0))
return 0;
return -EINVAL;
dlfb_setup_modes(dev, fb_info, src, src_size);
ret = dlfb_setup_modes(dev, fb_info, src, src_size);
if (ret)
return ret;
if (dev->edid && (memcmp(src, dev->edid, src_size) == 0)) {
pr_info("sysfs written EDID is new default\n");
dlfb_ops_set_par(fb_info);
return src_size;
} else
return 0;
if (!dev->edid || memcmp(src, dev->edid, src_size))
return -EINVAL;
pr_info("sysfs written EDID is new default\n");
dlfb_ops_set_par(fb_info);
return src_size;
}
static ssize_t metrics_reset_store(struct device *fbdev,