OpenE2K/linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

The type of sum in csum_tcpudp_nofold is "unsigned int", so when we assign

Browse Source 
to it in an asm() block, and we're running on a system with 64-bit
registers, it is vitally important that we sign extend it correctly before
returning to C.  Otherwise the stray high bits will be preserved into
csum_fold, and on the SB-1 processor, 32-bit arithmetic on a non
sign-extended register will yield surprising results.
    
This caused incorrect checksums in some UDP packets for NFS root.  The
problem was mild when using a 10.0.1.x IP address, but severe when
using 192.168.1.x.
    
Signed-off-by: Daniel Jacobowitz <dan@codesourcery.com>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
This commit is contained in:
Ralf Baechle 2005-09-20 10:56:26 +00:00
parent 2cce826322
commit e97288386a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/asm-mips/checksum.h
View File

@ -150,7 +150,7 @@ static inline unsigned int csum_tcpudp_nofold(unsigned long saddr,
" daddu %0, %4 \n"
" dsll32 $1, %0, 0 \n"
" daddu %0, $1 \n"
" dsrl32 %0, %0, 0 \n"
" dsra32 %0, %0, 0 \n"
#endif
" .set pop"
: "=r" (sum)