OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ps3fb: atomic fixes 

ps3fb: Use atomic_dec_if_positive() instead of bogus atomic_read()/atomic_dec()
combinations

Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Geert Uytterhoeven 2007-05-02 14:48:32 +02:00 committed by Linus Torvalds
parent 1c0c846119
commit eca28743b7
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/video/ps3fb.c
View File

@ -680,13 +680,10 @@ EXPORT_SYMBOL_GPL(ps3fb_wait_for_vsync);
void ps3fb_flip_ctl(int on) void ps3fb_flip_ctl(int on)
{ {
if (on) { if (on)
if (atomic_read(&ps3fb.ext_flip) > 0) { atomic_dec_if_positive(&ps3fb.ext_flip);
atomic_dec(&ps3fb.ext_flip); else
}
} else {
atomic_inc(&ps3fb.ext_flip); atomic_inc(&ps3fb.ext_flip);
}
} }
EXPORT_SYMBOL_GPL(ps3fb_flip_ctl); EXPORT_SYMBOL_GPL(ps3fb_flip_ctl);
@ -786,8 +783,7 @@ static int ps3fb_ioctl(struct fb_info *info, unsigned int cmd,
case PS3FB_IOCTL_OFF: case PS3FB_IOCTL_OFF:
DPRINTK("PS3FB_IOCTL_OFF:\n"); DPRINTK("PS3FB_IOCTL_OFF:\n");
if (atomic_read(&ps3fb.ext_flip) > 0) atomic_dec_if_positive(&ps3fb.ext_flip);
atomic_dec(&ps3fb.ext_flip);
retval = 0; retval = 0;
break; break;