OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] ioremap balanced with iounmap for drivers/video/virgefb 

ioremap must be balanced by an iounmap and failing to do so can result in a
memory leak.

Signed-off-by: Amol Lad <amol@verismonetworks.com>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Amol Lad 2006-12-08 02:40:02 -08:00 committed by Linus Torvalds
parent dd607d23ff
commit ef26dd7ffa
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/video/virgefb.c
View File

@ -1799,7 +1799,7 @@ int __init virgefb_init(void)
#warning release resources
printk(KERN_ERR "virgefb.c: register_framebuffer failed\n");
DPRINTK("EXIT\n");
return -EINVAL;
goto out_unmap;
}
printk(KERN_INFO "fb%d: %s frame buffer device, using %ldK of video memory\n",
@ -1809,6 +1809,21 @@ int __init virgefb_init(void)
DPRINTK("EXIT\n");
return 0;
out_unmap:
if (board_addr >= 0x01000000) {
if (v_ram)
iounmap((void*)v_ram);
if (vgaio_regs)
iounmap(vgaio_regs);
if (mmio_regs)
iounmap(mmio_regs);
if (vcode_switch_base)
iounmap((void*)vcode_switch_base);
v_ram = vcode_switch_base = 0;
vgaio_regs = mmio_regs = NULL;
}
return -EINVAL;
}