hwmon: (nsa320-hwmon) Use permission specific SENSOR[_DEVICE]_ATTR variants
Use SENSOR[_DEVICE]_ATTR[_2]_{RO,RW,WO} to simplify the source code, to improve readability, and to reduce the chance of inconsistencies. Also replace any remaining S_<PERMS> in the driver with octal values. The conversion was done automatically with coccinelle. The semantic patches and the scripts used to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
parent
e590be4ab1
commit
f0faf62c71
|
@ -114,8 +114,8 @@ static s32 nsa320_hwmon_update(struct device *dev)
|
|||
return mcu_data;
|
||||
}
|
||||
|
||||
static ssize_t show_label(struct device *dev,
|
||||
struct device_attribute *attr, char *buf)
|
||||
static ssize_t label_show(struct device *dev, struct device_attribute *attr,
|
||||
char *buf)
|
||||
{
|
||||
int channel = to_sensor_dev_attr(attr)->index;
|
||||
|
||||
|
@ -144,9 +144,9 @@ static ssize_t fan1_input_show(struct device *dev,
|
|||
return sprintf(buf, "%d\n", ((mcu_data & 0xff0000) >> 16) * 100);
|
||||
}
|
||||
|
||||
static SENSOR_DEVICE_ATTR(temp1_label, S_IRUGO, show_label, NULL, NSA320_TEMP);
|
||||
static SENSOR_DEVICE_ATTR_RO(temp1_label, label, NSA320_TEMP);
|
||||
static DEVICE_ATTR_RO(temp1_input);
|
||||
static SENSOR_DEVICE_ATTR(fan1_label, S_IRUGO, show_label, NULL, NSA320_FAN);
|
||||
static SENSOR_DEVICE_ATTR_RO(fan1_label, label, NSA320_FAN);
|
||||
static DEVICE_ATTR_RO(fan1_input);
|
||||
|
||||
static struct attribute *nsa320_attrs[] = {
|
||||
|
|
Loading…
Reference in New Issue