IB/hfi1: Compute BTH only for RDMA_WRITE_LAST/SEND_LAST packet
In hfi1_rc_rcv(), BTH is computed for all packets received. However, it's only used for packets received with opcodes RDMA_WRITE_LAST and SEND_LAST, and it is a costly operation. Compute BTH only in the RDMA_WRITE_LAST/SEND_LAST code path and let the compiler handle endianness conversion for bitwise operations. Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com> Signed-off-by: Sebastian Sanchez <sebastian.sanchez@intel.com> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
This commit is contained in:
parent
9636258f10
commit
f150e2736f
|
@ -2035,7 +2035,6 @@ void hfi1_rc_rcv(struct hfi1_packet *packet)
|
||||||
struct rvt_qp *qp = packet->qp;
|
struct rvt_qp *qp = packet->qp;
|
||||||
struct hfi1_ibport *ibp = rcd_to_iport(rcd);
|
struct hfi1_ibport *ibp = rcd_to_iport(rcd);
|
||||||
struct ib_other_headers *ohdr = packet->ohdr;
|
struct ib_other_headers *ohdr = packet->ohdr;
|
||||||
u32 bth0 = be32_to_cpu(ohdr->bth[0]);
|
|
||||||
u32 opcode = packet->opcode;
|
u32 opcode = packet->opcode;
|
||||||
u32 hdrsize = packet->hlen;
|
u32 hdrsize = packet->hlen;
|
||||||
u32 psn = ib_bth_get_psn(packet->ohdr);
|
u32 psn = ib_bth_get_psn(packet->ohdr);
|
||||||
|
@ -2233,7 +2232,7 @@ send_last:
|
||||||
wc.port_num = 0;
|
wc.port_num = 0;
|
||||||
/* Signal completion event if the solicited bit is set. */
|
/* Signal completion event if the solicited bit is set. */
|
||||||
rvt_cq_enter(ibcq_to_rvtcq(qp->ibqp.recv_cq), &wc,
|
rvt_cq_enter(ibcq_to_rvtcq(qp->ibqp.recv_cq), &wc,
|
||||||
(bth0 & IB_BTH_SOLICITED) != 0);
|
ib_bth_is_solicited(ohdr));
|
||||||
break;
|
break;
|
||||||
|
|
||||||
case OP(RDMA_WRITE_ONLY):
|
case OP(RDMA_WRITE_ONLY):
|
||||||
|
|
|
@ -478,8 +478,7 @@ last_imm:
|
||||||
wc.port_num = 0;
|
wc.port_num = 0;
|
||||||
/* Signal completion event if the solicited bit is set. */
|
/* Signal completion event if the solicited bit is set. */
|
||||||
rvt_cq_enter(ibcq_to_rvtcq(qp->ibqp.recv_cq), &wc,
|
rvt_cq_enter(ibcq_to_rvtcq(qp->ibqp.recv_cq), &wc,
|
||||||
(ohdr->bth[0] &
|
ib_bth_is_solicited(ohdr));
|
||||||
cpu_to_be32(IB_BTH_SOLICITED)) != 0);
|
|
||||||
break;
|
break;
|
||||||
|
|
||||||
case OP(RDMA_WRITE_FIRST):
|
case OP(RDMA_WRITE_FIRST):
|
||||||
|
|
|
@ -1045,8 +1045,7 @@ void hfi1_ud_rcv(struct hfi1_packet *packet)
|
||||||
wc.port_num = qp->port_num;
|
wc.port_num = qp->port_num;
|
||||||
/* Signal completion event if the solicited bit is set. */
|
/* Signal completion event if the solicited bit is set. */
|
||||||
rvt_cq_enter(ibcq_to_rvtcq(qp->ibqp.recv_cq), &wc,
|
rvt_cq_enter(ibcq_to_rvtcq(qp->ibqp.recv_cq), &wc,
|
||||||
(ohdr->bth[0] &
|
ib_bth_is_solicited(ohdr));
|
||||||
cpu_to_be32(IB_BTH_SOLICITED)) != 0);
|
|
||||||
return;
|
return;
|
||||||
|
|
||||||
drop:
|
drop:
|
||||||
|
|
|
@ -1916,8 +1916,7 @@ send_last:
|
||||||
wc.port_num = 0;
|
wc.port_num = 0;
|
||||||
/* Signal completion event if the solicited bit is set. */
|
/* Signal completion event if the solicited bit is set. */
|
||||||
rvt_cq_enter(ibcq_to_rvtcq(qp->ibqp.recv_cq), &wc,
|
rvt_cq_enter(ibcq_to_rvtcq(qp->ibqp.recv_cq), &wc,
|
||||||
(ohdr->bth[0] &
|
ib_bth_is_solicited(ohdr));
|
||||||
cpu_to_be32(IB_BTH_SOLICITED)) != 0);
|
|
||||||
break;
|
break;
|
||||||
|
|
||||||
case OP(RDMA_WRITE_FIRST):
|
case OP(RDMA_WRITE_FIRST):
|
||||||
|
|
|
@ -403,8 +403,7 @@ last_imm:
|
||||||
wc.port_num = 0;
|
wc.port_num = 0;
|
||||||
/* Signal completion event if the solicited bit is set. */
|
/* Signal completion event if the solicited bit is set. */
|
||||||
rvt_cq_enter(ibcq_to_rvtcq(qp->ibqp.recv_cq), &wc,
|
rvt_cq_enter(ibcq_to_rvtcq(qp->ibqp.recv_cq), &wc,
|
||||||
(ohdr->bth[0] &
|
ib_bth_is_solicited(ohdr));
|
||||||
cpu_to_be32(IB_BTH_SOLICITED)) != 0);
|
|
||||||
break;
|
break;
|
||||||
|
|
||||||
case OP(RDMA_WRITE_FIRST):
|
case OP(RDMA_WRITE_FIRST):
|
||||||
|
|
|
@ -581,8 +581,7 @@ void qib_ud_rcv(struct qib_ibport *ibp, struct ib_header *hdr,
|
||||||
wc.port_num = qp->port_num;
|
wc.port_num = qp->port_num;
|
||||||
/* Signal completion event if the solicited bit is set. */
|
/* Signal completion event if the solicited bit is set. */
|
||||||
rvt_cq_enter(ibcq_to_rvtcq(qp->ibqp.recv_cq), &wc,
|
rvt_cq_enter(ibcq_to_rvtcq(qp->ibqp.recv_cq), &wc,
|
||||||
(ohdr->bth[0] &
|
ib_bth_is_solicited(ohdr));
|
||||||
cpu_to_be32(IB_BTH_SOLICITED)) != 0);
|
|
||||||
return;
|
return;
|
||||||
|
|
||||||
drop:
|
drop:
|
||||||
|
|
|
@ -331,4 +331,8 @@ static inline u8 ib_bth_get_tver(struct ib_other_headers *ohdr)
|
||||||
IB_BTH_TVER_MASK);
|
IB_BTH_TVER_MASK);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
static inline bool ib_bth_is_solicited(struct ib_other_headers *ohdr)
|
||||||
|
{
|
||||||
|
return ohdr->bth[0] & cpu_to_be32(IB_BTH_SOLICITED);
|
||||||
|
}
|
||||||
#endif /* IB_HDRS_H */
|
#endif /* IB_HDRS_H */
|
||||||
|
|
Loading…
Reference in New Issue