ocfs2: fix panic on kfree(xattr->name)
Commit 9548906b2b
('xattr: Constify ->name member of "struct xattr"')
missed that ocfs2 is calling kfree(xattr->name). As a result, kernel
panic occurs upon calling kfree(xattr->name) because xattr->name refers
static constant names. This patch removes kfree(xattr->name) from
ocfs2_mknod() and ocfs2_symlink().
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reported-by: Tariq Saeed <tariq.x.saeed@oracle.com>
Tested-by: Tariq Saeed <tariq.x.saeed@oracle.com>
Reviewed-by: Srinivas Eeda <srinivas.eeda@oracle.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: <stable@vger.kernel.org> [3.12+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
f7cf4f5bfe
commit
f81c20158f
|
@ -450,7 +450,6 @@ leave:
|
||||||
|
|
||||||
brelse(new_fe_bh);
|
brelse(new_fe_bh);
|
||||||
brelse(parent_fe_bh);
|
brelse(parent_fe_bh);
|
||||||
kfree(si.name);
|
|
||||||
kfree(si.value);
|
kfree(si.value);
|
||||||
|
|
||||||
ocfs2_free_dir_lookup_result(&lookup);
|
ocfs2_free_dir_lookup_result(&lookup);
|
||||||
|
@ -1856,7 +1855,6 @@ bail:
|
||||||
|
|
||||||
brelse(new_fe_bh);
|
brelse(new_fe_bh);
|
||||||
brelse(parent_fe_bh);
|
brelse(parent_fe_bh);
|
||||||
kfree(si.name);
|
|
||||||
kfree(si.value);
|
kfree(si.value);
|
||||||
ocfs2_free_dir_lookup_result(&lookup);
|
ocfs2_free_dir_lookup_result(&lookup);
|
||||||
if (inode_ac)
|
if (inode_ac)
|
||||||
|
|
Loading…
Reference in New Issue