OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

hwmon: (asus_atk0110) Fix debugfs_simple_attr.cocci warnings 

Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
for debugfs files.

Semantic patch information:
Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
imposes some significant overhead as compared to
DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().

Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
YueHaibing 2018-12-12 08:36:36 +00:00 committed by Guenter Roeck
parent 626f5eaed1
commit f9facc24a6
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/hwmon/asus_atk0110.c
View File

@ -681,9 +681,7 @@ static int atk_debugfs_gitm_get(void *p, u64 *val)
return err; return err;
} }
DEFINE_SIMPLE_ATTRIBUTE(atk_debugfs_gitm, DEFINE_DEBUGFS_ATTRIBUTE(atk_debugfs_gitm, atk_debugfs_gitm_get, NULL,
atk_debugfs_gitm_get,
NULL,
"0x%08llx\n"); "0x%08llx\n");
static int atk_acpi_print(char *buf, size_t sz, union acpi_object *obj) static int atk_acpi_print(char *buf, size_t sz, union acpi_object *obj)
@ -803,7 +801,7 @@ static void atk_debugfs_init(struct atk_data *data)
if (!f || IS_ERR(f)) if (!f || IS_ERR(f))
goto cleanup; goto cleanup;
f = debugfs_create_file("gitm", 0400, d, data, f = debugfs_create_file_unsafe("gitm", 0400, d, data,
&atk_debugfs_gitm); &atk_debugfs_gitm);
if (!f || IS_ERR(f)) if (!f || IS_ERR(f))
goto cleanup; goto cleanup;