OpenE2K/linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tty: n_gsm: fix malformed counter for out of frame data

Browse Source 
commit a24b4b2f660b7ddf3f484b37600bba382cb28a9d upstream.

The gsm_mux field 'malformed' represents the number of malformed frames
received. However, gsm1_receive() also increases this counter for any out
of frame byte.
Fix this by ignoring out of frame data for the malformed counter.

Fixes: e1eaea46bb ("tty: n_gsm line discipline")
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
Link: https://lore.kernel.org/r/20220414094225.4527-7-daniel.starke@siemens.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Daniel Starke 2022-04-14 02:42:12 -07:00 committed by Greg Kroah-Hartman
parent cec2d0782a
commit fae2095210
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/tty/n_gsm.c
View File

@ -1961,7 +1961,8 @@ static void gsm1_receive(struct gsm_mux *gsm, unsigned char c)
} }
/* Any partial frame was a runt so go back to start */ /* Any partial frame was a runt so go back to start */
if (gsm->state != GSM_START) { if (gsm->state != GSM_START) {
gsm->malformed++; if (gsm->state != GSM_SEARCH)
gsm->malformed++;
gsm->state = GSM_START; gsm->state = GSM_START;
} }
/* A SOF in GSM_START means we are still reading idling or /* A SOF in GSM_START means we are still reading idling or