Nicolas Iooss 0f5aa88a7b ceph: do not modify fi->frag in need_reset_readdir() ... Commit f3c4ebe65e ("ceph: using hash value to compose dentry offset") modified "if (fpos_frag(new_pos) != fi->frag)" to "if (fi->frag |= fpos_frag(new_pos))" in need_reset_readdir(), thus replacing a comparison operator with an assignment one. This looks like a typo which is reported by clang when building the kernel with some warning flags: fs/ceph/dir.c:600:22: error: using the result of an assignment as a condition without parentheses [-Werror,-Wparentheses] } else if (fi->frag |= fpos_frag(new_pos)) { ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ fs/ceph/dir.c:600:22: note: place parentheses around the assignment to silence this warning } else if (fi->frag |= fpos_frag(new_pos)) { ^ ( ) fs/ceph/dir.c:600:22: note: use '!=' to turn this compound assignment into an inequality comparison } else if (fi->frag |= fpos_frag(new_pos)) { ^~ != Fixes: f3c4ebe65e ("ceph: using hash value to compose dentry offset") Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>		2016-09-05 14:30:35 +02:00
..
acl.c
addr.c
cache.c
cache.h
caps.c	ceph: fix null pointer dereference in ceph_flush_snaps()	2016-08-08 21:41:43 +02:00
ceph_frag.c
debugfs.c
dir.c	ceph: do not modify fi->frag in need_reset_readdir()	2016-09-05 14:30:35 +02:00
export.c
file.c	ceph: Correctly return NXIO errors from ceph_llseek	2016-07-28 03:00:45 +02:00
inode.c	The highlights are:	2016-08-02 19:39:09 -04:00
ioctl.c
ioctl.h
Kconfig
locks.c
Makefile
mds_client.c	ceph: initialize pathbase in the !dentry case in encode_caps_cb()	2016-08-09 17:26:56 +02:00
mds_client.h	ceph: unify cap flush and snapcap flush	2016-07-28 03:00:42 +02:00
mdsmap.c
snap.c	ceph: cleanup ceph_flush_snaps()	2016-07-28 03:00:44 +02:00
strings.c
super.c	ceph: Mark the file cache as unreclaimable	2016-07-28 03:00:45 +02:00
super.h	ceph: optimize cap flush waiting	2016-07-28 03:00:45 +02:00
xattr.c