linux/net/sunrpc
Chuck Lever 7e69c9e6bb SUNRPC: Fix backchannel RPC soft lockups
commit 6221f1d9b6 upstream.

Currently, after the forward channel connection goes away,
backchannel operations are causing soft lockups on the server
because call_transmit_status's SOFTCONN logic ignores ENOTCONN.
Such backchannel Calls are aggressively retried until the client
reconnects.

Backchannel Calls should use RPC_TASK_NOCONNECT rather than
RPC_TASK_SOFTCONN. If there is no forward connection, the server is
not capable of establishing a connection back to the client, thus
that backchannel request should fail before the server attempts to
send it. Commit 58255a4e3c ("NFSD: NFSv4 callback client should
use RPC_TASK_SOFTCONN") was merged several years before
RPC_TASK_NOCONNECT was available.

Because setup_callback_client() explicitly sets NOPING, the NFSv4.0
callback connection depends on the first callback RPC to initiate
a connection to the client. Thus NFSv4.0 needs to continue to use
RPC_TASK_SOFTCONN.

Suggested-by: Trond Myklebust <trondmy@hammerspace.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Cc: <stable@vger.kernel.org> # v4.20+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-04-29 16:33:18 +02:00
..
auth_gss sunrpc: Fix gss_unwrap_resp_integ() again 2020-04-23 10:36:41 +02:00
xprtrdma SUNRPC: Fix backchannel RPC soft lockups 2020-04-29 16:33:18 +02:00
Kconfig
Makefile
addr.c
auth.c
auth_null.c
auth_unix.c
backchannel_rqst.c
cache.c sunrpc: Fix potential leaks in sunrpc_cache_unhash() 2020-02-24 08:36:55 +01:00
clnt.c
debugfs.c
netns.h
rpc_pipe.c
rpcb_clnt.c
sched.c
socklib.c
stats.c
sunrpc.h
sunrpc_syms.c
svc.c
svc_xprt.c SUNRPC: Fix backchannel RPC soft lockups 2020-04-29 16:33:18 +02:00
svcauth.c
svcauth_unix.c
svcsock.c
sysctl.c
timer.c
xdr.c SUNRPC: Fix another issue with MIC buffer space 2020-01-26 10:01:07 +01:00
xprt.c
xprtmultipath.c
xprtsock.c SUNRPC: Fix backchannel RPC soft lockups 2020-04-29 16:33:18 +02:00