Shaohua Li 05c30b9551 block: fix NULL icq_cache reference ... Vivek reported a kernel crash: [ 94.217015] BUG: unable to handle kernel NULL pointer dereference at 000000000000001c [ 94.218004] IP: [<ffffffff81142fae>] kmem_cache_free+0x5e/0x200 [ 94.218004] PGD 13abda067 PUD 137d52067 PMD 0 [ 94.218004] Oops: 0000 [#1] SMP DEBUG_PAGEALLOC [ 94.218004] CPU 0 [ 94.218004] Modules linked in: [last unloaded: scsi_wait_scan] [ 94.218004] [ 94.218004] Pid: 0, comm: swapper/0 Not tainted 3.2.0+ #16 Hewlett-Packard HP xw6600 Workstation/0A9Ch [ 94.218004] RIP: 0010:[<ffffffff81142fae>] [<ffffffff81142fae>] kmem_cache_free+0x5e/0x200 [ 94.218004] RSP: 0018:ffff88013fc03de0 EFLAGS: 00010006 [ 94.218004] RAX: ffffffff81e0d020 RBX: ffff880138b3c680 RCX: 00000001801c001b [ 94.218004] RDX: 00000000003aac1d RSI: ffff880138b3c680 RDI: ffffffff81142fae [ 94.218004] RBP: ffff88013fc03e10 R08: ffff880137830238 R09: 0000000000000001 [ 94.218004] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 [ 94.218004] R13: ffffea0004e2cf00 R14: ffffffff812f6eb6 R15: 0000000000000246 [ 94.218004] FS: 0000000000000000(0000) GS:ffff88013fc00000(0000) knlGS:0000000000000000 [ 94.218004] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b [ 94.218004] CR2: 000000000000001c CR3: 00000001395ab000 CR4: 00000000000006f0 [ 94.218004] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 94.218004] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 [ 94.218004] Process swapper/0 (pid: 0, threadinfo ffffffff81e00000, task ffffffff81e0d020) [ 94.218004] Stack: [ 94.218004] 0000000000000102 ffff88013fc0db20 ffffffff81e22700 ffff880139500f00 [ 94.218004] 0000000000000001 000000000000000a ffff88013fc03e20 ffffffff812f6eb6 [ 94.218004] ffff88013fc03e90 ffffffff810c8da2 ffffffff81e01fd8 ffff880137830240 [ 94.218004] Call Trace: [ 94.218004] <IRQ> [ 94.218004] [<ffffffff812f6eb6>] icq_free_icq_rcu+0x16/0x20 [ 94.218004] [<ffffffff810c8da2>] __rcu_process_callbacks+0x1c2/0x420 [ 94.218004] [<ffffffff810c9038>] rcu_process_callbacks+0x38/0x250 [ 94.218004] [<ffffffff810405ee>] __do_softirq+0xce/0x3e0 [ 94.218004] [<ffffffff8108ed04>] ? clockevents_program_event+0x74/0x100 [ 94.218004] [<ffffffff81090104>] ? tick_program_event+0x24/0x30 [ 94.218004] [<ffffffff8183ed1c>] call_softirq+0x1c/0x30 [ 94.218004] [<ffffffff8100422d>] do_softirq+0x8d/0xc0 [ 94.218004] [<ffffffff81040c3e>] irq_exit+0xae/0xe0 [ 94.218004] [<ffffffff8183f4be>] smp_apic_timer_interrupt+0x6e/0x99 [ 94.218004] [<ffffffff8183e330>] apic_timer_interrupt+0x70/0x80 Once a queue is quiesced, it's not supposed to have any elvpriv data or icq's, and elevator switching depends on that. Request alloc path followed the rule for elvpriv data but forgot apply it to icq's leading to the following crash during elevator switch. Fix it by not allocating icq's if ELVPRIV is not set for the request. Reported-by: Vivek Goyal <vgoyal@redhat.com> Tested-by: Vivek Goyal <vgoyal@redhat.com> Signed-off-by: Shaohua Li <shaohua.li@intel.com> Acked-by: Tejun Heo <tj@kernel.org> Signed-off-by: Jens Axboe <axboe@kernel.dk>		2012-01-19 09:20:10 +01:00
..
partitions	separate partition format handling from generic code	2012-01-03 22:54:06 -05:00
blk-cgroup.c	Merge branch 'for-3.3/core' of git://git.kernel.dk/linux-block	2012-01-15 12:24:45 -08:00
blk-cgroup.h	block: fix a typo in the blk-cgroup.h file	2011-10-24 16:08:38 +02:00
blk-core.c	block: fix NULL icq_cache reference	2012-01-19 09:20:10 +01:00
blk-exec.c	block: add missing blk_queue_dead() checks	2011-12-14 00:33:37 +01:00
blk-flush.c	blk-flush: move the queue kick into	2011-10-24 16:24:31 +02:00
blk-integrity.c	block: add export.h to files using EXPORT_SYMBOL/THIS_MODULE macros	2011-10-31 19:31:12 -04:00
blk-ioc.c	block: remove WARN_ON_ONCE() in exit_io_context()	2011-12-27 18:52:16 +01:00
blk-iopoll.c
blk-lib.c	block: fix patch import error in max_discard_sectors check	2011-07-23 20:34:59 +02:00
blk-map.c	block: re-use existing 'reading' variable instead of checking direction again	2011-12-21 15:27:24 +01:00
blk-merge.c	block: attempt to merge with existing requests on plug flush	2011-03-21 10:14:27 +01:00
blk-settings.c	block: Introduce blk_set_stacking_limits function	2012-01-11 16:27:11 +01:00
blk-softirq.c	block: Don't check QUEUE_FLAG_SAME_COMP in __blk_complete_request	2011-09-14 09:31:01 +02:00
blk-sysfs.c	block, cfq: move io_cq exit/release to blk-ioc.c	2011-12-14 00:33:42 +01:00
blk-tag.c	block: fix blk_queue_end_tag()	2011-12-29 09:16:28 +01:00
blk-throttle.c	block: add blk_queue_dead()	2011-12-14 00:33:37 +01:00
blk-timeout.c	fault-injection: add ability to export fault_attr in arbitrary directory	2011-08-03 14:25:20 -10:00
blk.h	block, cfq: move icq creation and rq->elv.icq association to block core	2011-12-14 00:33:42 +01:00
bsg-lib.c	block: Change module.h -> export.h in bsg-lib.c	2011-10-31 19:31:13 -04:00
bsg.c	Merge branch 'for-3.3/core' of git://git.kernel.dk/linux-block	2012-01-15 12:24:45 -08:00
cfq-iosched.c	block,cfq: change code order	2012-01-19 09:20:09 +01:00
cfq.h
compat_ioctl.c	block: Add BLKROTATIONAL ioctl	2012-01-11 16:29:31 +01:00
deadline-iosched.c	block, cfq: move icq cache management to block core	2011-12-14 00:33:42 +01:00
elevator.c	Revert "block: recursive merge requests"	2012-01-15 10:29:48 +01:00
genhd.c	Merge branch 'for-3.3/core' of git://git.kernel.dk/linux-block	2012-01-15 12:24:45 -08:00
ioctl.c	Merge branch 'for-3.3/core' of git://git.kernel.dk/linux-block	2012-01-15 12:24:45 -08:00
Kconfig	move fs/partitions to block/	2012-01-03 22:54:06 -05:00
Kconfig.iosched
Makefile	separate partition format handling from generic code	2012-01-03 22:54:06 -05:00
noop-iosched.c	block, cfq: move icq cache management to block core	2011-12-14 00:33:42 +01:00
partition-generic.c	separate partition format handling from generic code	2012-01-03 22:54:06 -05:00
scsi_ioctl.c	block: fail SCSI passthrough ioctls on partition devices	2012-01-14 15:07:24 -08:00