linux/drivers/net/fjes
Johannes Berg 59ae1d127a networking: introduce and use skb_put_data()
A common pattern with skb_put() is to just want to memcpy()
some data into the new space, introduce skb_put_data() for
this.

An spatch similar to the one for skb_put_zero() converts many
of the places using it:

    @@
    identifier p, p2;
    expression len, skb, data;
    type t, t2;
    @@
    (
    -p = skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    |
    -p = (t)skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, len);
    |
    -memcpy(p, data, len);
    )

    @@
    type t, t2;
    identifier p, p2;
    expression skb, data;
    @@
    t *p;
    ...
    (
    -p = skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    |
    -p = (t *)skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, sizeof(*p));
    |
    -memcpy(p, data, sizeof(*p));
    )

    @@
    expression skb, len, data;
    @@
    -memcpy(skb_put(skb, len), data, len);
    +skb_put_data(skb, data, len);

(again, manually post-processed to retain some comments)

Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-16 11:48:37 -04:00
..
Makefile fjes: Add debugfs entry for EP status information in fjes driver 2016-10-14 12:04:58 -04:00
fjes.h fjes: Add debugfs entry for EP status information in fjes driver 2016-10-14 12:04:58 -04:00
fjes_debugfs.c fjes: Add debugfs entry for EP status information in fjes driver 2016-10-14 12:04:58 -04:00
fjes_ethtool.c net: fjes: use new api ethtool_{get|set}_link_ksettings 2017-03-12 19:28:07 -07:00
fjes_hw.c fjes: ethtool -w and -W support for fjes driver 2016-10-14 12:04:57 -04:00
fjes_hw.h fjes: ethtool -w and -W support for fjes driver 2016-10-14 12:04:57 -04:00
fjes_main.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
fjes_regs.h
fjes_trace.c fjes: Add tracepoints in fjes driver 2016-10-14 12:04:57 -04:00
fjes_trace.h fjes: fix format string for trace output 2016-10-17 13:07:52 -04:00