Jiri Slaby fa90e1c935 TTY: make tty_add_file non-failing ... If tty_add_file fails at the point it is now, we have to revert all the changes we did to the tty. It means either decrease all refcounts if this was a tty reopen or delete the tty if it was newly allocated. There was a try to fix this in v3.0-rc2 using tty_release in 0259894c7 (TTY: fix fail path in tty_open). But instead it introduced a NULL dereference. It's because tty_release dereferences filp->private_data, but that one is set even in our tty_add_file. And when tty_add_file fails, it's still NULL/garbage. Hence tty_release cannot be called there. To circumvent the original leak (and the current NULL deref) we split tty_add_file into two functions, making the latter non-failing. In that case we may do the former early in open, where handling failures is easy. The latter stays as it is now. So there is no change in functionality. The original bug (leak) was introduced by f573bd176 (tty: Remove __GFP_NOFAIL from tty_add_file()). Thanks Dan for reporting this. Later, we may split tty_release into more functions and call only some of them in this fail path instead. (If at all possible.) Introduced-in: v2.6.37-rc2 Signed-off-by: Jiri Slaby <jslaby@suse.cz> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: stable <stable@vger.kernel.org> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Cc: Pekka Enberg <penberg@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>		2011-10-18 14:22:37 -07:00
..
acpi	Merge branch 'apei-release' of git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6	2011-08-03 21:53:27 -10:00
asm-generic	mm: fix __page_to_pfn for a const struct page argument	2011-08-17 13:00:20 -07:00
crypto	…
drm	drm: Separate EDID Header Check from EDID Block Check	2011-08-04 14:39:35 +01:00
keys	…
linux	TTY: make tty_add_file non-failing	2011-10-18 14:22:37 -07:00
math-emu	…
media	…
mtd	…
net	ipv4: route non-local sources for raw socket	2011-08-07 22:52:32 -07:00
pcmcia	…
rdma	…
rxrpc	…
scsi	Merge branch 'for-linus' of git://git.open-osd.org/linux-open-osd	2011-08-06 22:56:03 -07:00
sound	ASoC: omap: Update e-mail address of Jarkko Nikula	2011-08-12 11:45:10 +09:00
target	…
trace	Merge branch 'for-linus' of git://git.kernel.dk/linux-block	2011-08-19 10:47:07 -07:00
video	…
xen	…
Kbuild	…