ba6c4033b9
rtc is clearly does not satisfy IS_ERR at the point where it is tested, so I have changed the test to consider the just initialized rtc->rtc_dev. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @match exists@ expression x, E; identifier fld; position p1,p2; @@ ( x = E; | x = E | x@p1->fld ... when != x = E IS_ERR(x@p2) ... when any ) @other_match exists@ expression match.x, E1, E2; position match.p1,match.p2; @@ x = E1 ... when != x = E2 when != x@p1 x@p2 @ script:python depends on !other_match@ p1 << match.p1; p2 << match.p2; @@ print "* file %s dereference %s test %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: Alessandro Zummo <a.zummo@towertech.it> Cc: David Brownell <david-b@pacbell.net> Cc: Bryan Wu <bryan.wu@analog.com> Cc: Mike Frysinger <michael.frysinger@analog.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
---|---|---|
.. | ||
class.c | ||
hctosys.c | ||
interface.c | ||
Kconfig | ||
Makefile | ||
rtc-at32ap700x.c | ||
rtc-at91rm9200.c | ||
rtc-at91sam9.c | ||
rtc-au1xxx.c | ||
rtc-bfin.c | ||
rtc-bq4802.c | ||
rtc-cmos.c | ||
rtc-core.h | ||
rtc-dev.c | ||
rtc-ds1216.c | ||
rtc-ds1286.c | ||
rtc-ds1302.c | ||
rtc-ds1305.c | ||
rtc-ds1307.c | ||
rtc-ds1374.c | ||
rtc-ds1390.c | ||
rtc-ds1511.c | ||
rtc-ds1553.c | ||
rtc-ds1672.c | ||
rtc-ds1742.c | ||
rtc-ds3234.c | ||
rtc-ep93xx.c | ||
rtc-fm3130.c | ||
rtc-isl1208.c | ||
rtc-lib.c | ||
rtc-m41t80.c | ||
rtc-m41t94.c | ||
rtc-m48t35.c | ||
rtc-m48t59.c | ||
rtc-m48t86.c | ||
rtc-max6900.c | ||
rtc-max6902.c | ||
rtc-mv.c | ||
rtc-omap.c | ||
rtc-parisc.c | ||
rtc-pcf8563.c | ||
rtc-pcf8583.c | ||
rtc-pl030.c | ||
rtc-pl031.c | ||
rtc-ppc.c | ||
rtc-proc.c | ||
rtc-pxa.c | ||
rtc-r9701.c | ||
rtc-rs5c313.c | ||
rtc-rs5c348.c | ||
rtc-rs5c372.c | ||
rtc-rx8581.c | ||
rtc-s3c.c | ||
rtc-s35390a.c | ||
rtc-sa1100.c | ||
rtc-sh.c | ||
rtc-starfire.c | ||
rtc-stk17ta8.c | ||
rtc-sun4v.c | ||
rtc-sysfs.c | ||
rtc-test.c | ||
rtc-twl4030.c | ||
rtc-tx4939.c | ||
rtc-v3020.c | ||
rtc-vr41xx.c | ||
rtc-wm8350.c | ||
rtc-x1205.c |