linux/drivers/staging/comedi
Ian Abbott 922b67c1ac staging: comedi: ni_labpc: fix possible NULL deref during detach
`labpc_common_detach()` is called by the comedi core to clean up if
either `labpc_attach()` (including the one in the "ni_labpc_cs" module)
or `labpc_attach_pci()` returns an error.  It assumes the `thisboard`
macro (expanding to `((struct labpc_board_struct *)dev->board_ptr)`) is
non-null.  This is a valid assumption if `labpc_attach()` fails, but not
if `labpc_attach_pci()` fails, leading to a possible NULL pointer
dereference.

Check `thisboard` at the top of `labpc_common_detach()` and return early
if it is `NULL`.  This is okay because the only other thing that could
have been allocated is `dev->private` and that is freed by the comedi
core, not by this function.

Cc: <stable@vger.kernel.org> # 3.6.x
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2012-10-22 11:46:35 -07:00
..
drivers staging: comedi: ni_labpc: fix possible NULL deref during detach 2012-10-22 11:46:35 -07:00
kcomedilib staging: comedi: kcomedilib: fix a __user space access issue 2012-09-21 09:26:20 -07:00
Kconfig staging: comedi: 8255_pci: move ni_pcidio 8255 board support 2012-09-13 20:13:03 -07:00
Makefile Staging: comedi: Makefile: replace the use of <module>-objs with <module>-y 2010-10-08 07:23:52 -07:00
TODO Staging: comedi: Remove typedefs 2010-06-17 13:49:07 -07:00
comedi.h staging: comedi: comedi.h: remove __user tag from chanlist 2012-09-19 09:36:44 +01:00
comedi_compat32.c staging: comedi: shrink comedi_compat32.h 2012-06-20 12:57:43 -07:00
comedi_compat32.h staging: comedi: shrink comedi_compat32.h 2012-06-20 12:57:43 -07:00
comedi_fops.c staging: comedi: fix memory leak for saved channel list 2012-09-21 09:29:53 -07:00
comedi_internal.h staging: comedi: remove comedi_fops.h 2012-06-20 12:56:55 -07:00
comedidev.h staging: comedi: replace printk calls in comedi core 2012-08-16 11:35:45 -07:00
comedilib.h Staging: comedi: kcomedilib: make it typesafe 2010-05-11 11:36:02 -07:00
drivers.c staging: comedi: sparse warning in insn_rw_emulate_bits() 2012-09-19 11:26:12 +01:00
proc.c staging: comedi: remove comedi_fops.h 2012-06-20 12:56:55 -07:00
range.c staging: comedi: range: remove subdevice pointer math 2012-09-05 20:06:32 -07:00