OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
linux/drivers/isdn/hardware/eicon
History
Alexey Dobriyan 99b7623380 proc 2/2: remove struct proc_dir_entry::owner 
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.

We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.

But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.

->read_proc/->write_proc were just fixed to not require ->owner for
protection.

rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.

Removing ->owner will also make PDE smaller.

So, let's nuke it.

Kudos to Jeff Layton for reminding about this, let's say, oversight.

http://bugzilla.kernel.org/show_bug.cgi?id=12454

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
 		2009-03-31 01:14:44 +04:00
..
Kconfig Use menuconfig objects: ISDN: CONFIG_CAPI_EICON 2007-07-17 10:23:06 -07:00
Makefile Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
adapter.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
capi20.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
capidtmf.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
capidtmf.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
capifunc.c Spelling fix: explicitly 2007-10-19 23:22:55 +02:00
capifunc.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
capimain.c header cleaning: don't include smp_lock.h when not used 2007-05-08 11:15:07 -07:00
cardtype.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
cp_vers.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
dadapter.c [PATCH] drivers/isdn/: make some code static 2005-06-28 21:20:31 -07:00
dadapter.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
debug.c drivers/isdn/hardware/icon: fix sparse warning: cast truncates bits 2009-02-27 01:00:42 -08:00
debug_if.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
debuglib.c Typoes: "whith" -> "with" 2008-02-03 15:14:02 +02:00
debuglib.h fix similar typos to successfull 2009-01-08 08:31:15 -08:00
dfifo.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
di.c isdn: eicon: fix sparse warning: make global functions static 2008-12-16 01:17:33 -08:00
di.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
di_dbg.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
di_defs.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
did_vers.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
diddfunc.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
diva.c Remove pointless casts from void pointers 2008-02-06 10:41:01 -08:00
diva.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
diva_didd.c [NET]: Make /proc/net per network namespace 2007-10-10 16:49:06 -07:00
diva_dma.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
diva_dma.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
diva_pci.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
divacapi.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
divamnt.c divamnt: BKL pushdown 2008-06-20 14:05:52 -06:00
divasfunc.c isdn/diva: fix section mismatch 2007-06-08 17:23:33 -07:00
divasi.c proc 2/2: remove struct proc_dir_entry::owner 2009-03-31 01:14:44 +04:00
divasmain.c Merge commit 'v2.6.26' into bkl-removal 2008-07-14 15:29:34 -06:00
divasproc.c isdn divas: fix proc creation 2008-06-10 12:49:31 -07:00
divasync.h Fix occurrences of "the the " 2007-05-09 08:57:56 +02:00
dqueue.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
dqueue.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
dsp_defs.h [PATCH] EICON ISDN: Removed unused definitions for OS_SEEK_* 2006-10-01 00:39:21 -07:00
dsp_tst.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
dspdids.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
dsrv4bri.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
dsrv_bri.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
dsrv_pri.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
entity.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
helpers.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
idifunc.c i4l: leak in eicon/idifunc.c 2007-07-17 10:23:06 -07:00
io.c [PATCH] drivers/isdn: Handcrafted MIN/MAX Macro removal 2006-12-08 08:29:01 -08:00
io.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
istream.c [PATCH] drivers/isdn: Handcrafted MIN/MAX Macro removal 2006-12-08 08:29:01 -08:00
kst_ifc.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
maintidi.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
maintidi.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
man_defs.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
mdm_msg.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
message.c drivers/isdn/hardware/eicon: fix sparse warnings: Should it be static? 2009-02-27 01:00:43 -08:00
mi_pc.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
mntfunc.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
os_4bri.c fix similar typos to successfull 2009-01-08 08:31:15 -08:00
os_4bri.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
os_bri.c fix similar typos to successfull 2009-01-08 08:31:15 -08:00
os_bri.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
os_capi.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
os_pri.c fix similar typos to successfull 2009-01-08 08:31:15 -08:00
os_pri.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
pc.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
pc_init.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
pc_maint.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
pkmaint.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
platform.h header cleaning: don't include smp_lock.h when not used 2007-05-08 11:15:07 -07:00
pr_pc.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
s_4bri.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
s_bri.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
s_pri.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
sdp_hdr.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
um_idi.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
um_idi.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
um_xdi.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
xdi_adapter.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
xdi_msg.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
xdi_vers.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00