Hans Verkuil fac710e45d [media] vb2: fix nasty vb2_thread regression ... The vb2_thread implementation was made generic and was moved from videobuf2-v4l2.c to videobuf2-core.c in commit af3bac1a. Unfortunately that clearly was never tested since it broke read() causing NULL address references. The root cause was confused handling of vb2_buffer vs v4l2_buffer (the pb pointer in various core functions). The v4l2_buffer no longer exists after moving the code into the core and it is no longer needed. However, the vb2_thread code passed a pointer to a vb2_buffer to the core functions were a v4l2_buffer pointer was expected and vb2_thread expected that the vb2_buffer fields would be filled in correctly. This is obviously wrong since v4l2_buffer != vb2_buffer. Note that the pb pointer is a void pointer, so no type-checking took place. This patch fixes this problem: 1) allow pb to be NULL for vb2_core_(d)qbuf. The vb2_thread code will use a NULL pointer here since they don't care about v4l2_buffer anyway. 2) let vb2_core_dqbuf pass back the index of the received buffer. This is all vb2_thread needs: this index is the index into the q->bufs array and vb2_thread just gets the vb2_buffer from there. 3) the fileio->b pointer (that originally contained a v4l2_buffer) is removed altogether since it is no longer needed. Tested with vivid and the cobalt driver. Cc: stable@vger.kernel.org # Kernel >= 4.3 Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Reported-by: Matthias Schwarzott <zzam@gentoo.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>		2016-02-04 09:13:46 -02:00
..
blackfin	…
davinci	…
drv-intf	…
i2c	…
i2c-addr.h	…
lirc.h	…
lirc_dev.h	…
media-device.h	…
media-devnode.h	…
media-entity.h	…
rc-core.h	…
rc-map.h	…
soc_camera.h	…
tuner-types.h	…
tuner.h	…
tveeprom.h	…
v4l2-async.h	…
v4l2-clk.h	…
v4l2-common.h	…
v4l2-ctrls.h	…
v4l2-dev.h	…
v4l2-device.h	…
v4l2-dv-timings.h	…
v4l2-event.h	…
v4l2-fh.h	…
v4l2-flash-led-class.h	…
v4l2-image-sizes.h	…
v4l2-ioctl.h	…
v4l2-mediabus.h	…
v4l2-mem2mem.h	…
v4l2-of.h	…
v4l2-subdev.h	…
videobuf-core.h	…
videobuf-dma-contig.h	…
videobuf-dma-sg.h	…
videobuf-dvb.h	…
videobuf-vmalloc.h	…
videobuf2-core.h	[media] vb2: fix nasty vb2_thread regression	2016-02-04 09:13:46 -02:00
videobuf2-dma-contig.h	…
videobuf2-dma-sg.h	…
videobuf2-dvb.h	…
videobuf2-memops.h	…
videobuf2-v4l2.h	…
videobuf2-vmalloc.h	…