OpenE2K/linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
221af7f87b
linux/net/irda
History
André Goddard Rosa e7d2860b69 tree-wide: convert open calls to remove spaces to skip_spaces() lib function 
Makes use of skip_spaces() defined in lib/string.c for removing leading
spaces from strings all over the tree.

It decreases lib.a code size by 47 bytes and reuses the function tree-wide:
   text    data     bss     dec     hex filename
  64688     584     592   65864   10148 (TOTALS-BEFORE)
  64641     584     592   65817   10119 (TOTALS-AFTER)

Also, while at it, if we see (*str && isspace(*str)), we can be sure to
remove the first condition (*str) as the second one (isspace(*str)) also
evaluates to 0 whenever *str == 0, making it redundant. In other words,
"a char equals zero is never a space".

Julia Lawall tried the semantic patch (http://coccinelle.lip6.fr) below,
and found occurrences of this pattern on 3 more files:
    drivers/leds/led-class.c
    drivers/leds/ledtrig-timer.c
    drivers/video/output.c

@@
expression str;
@@

( // ignore skip_spaces cases
while (*str &&  isspace(*str)) { \(str++;\|++str;\) }
|
- *str &&
isspace(*str)
)

Signed-off-by: André Goddard Rosa <andre.goddard@gmail.com>
Cc: Julia Lawall <julia@diku.dk>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Neil Brown <neilb@suse.de>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: David Howells <dhowells@redhat.com>
Cc: <linux-ext4@vger.kernel.org>
Cc: Samuel Ortiz <samuel@sortiz.org>
Cc: Patrick McHardy <kaber@trash.net>
Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-15 08:53:32 -08:00
..
ircomm headers: remove sched.h from interrupt.h 2009-10-11 11:20:58 -07:00
irlan headers: remove sched.h from interrupt.h 2009-10-11 11:20:58 -07:00
irnet tree-wide: convert open calls to remove spaces to skip_spaces() lib function 2009-12-15 08:53:32 -08:00
af_irda.c net/irda: push BKL into proto_ops 2009-11-07 00:46:39 -08:00
discovery.c
irda_device.c
iriap_event.c
iriap.c net: mark read-only arrays as const 2009-08-05 10:42:58 -07:00
irias_object.c
irlap_event.c tree-wide: fix assorted typos all over the place 2009-12-04 15:39:55 +01:00
irlap_frame.c irda: Use SKB queue and list helpers instead of doing it by-hand. 2009-05-28 23:26:33 -07:00
irlap.c tree-wide: fix assorted typos all over the place 2009-12-04 15:39:55 +01:00
irlmp_event.c net: mark read-only arrays as const 2009-08-05 10:42:58 -07:00
irlmp_frame.c
irlmp.c tree-wide: fix assorted typos all over the place 2009-12-04 15:39:55 +01:00
irmod.c
irnetlink.c genetlink: make netns aware 2009-07-12 14:03:27 -07:00
irproc.c net: file_operations should be const 2009-09-02 01:03:53 -07:00
irqueue.c
irsysctl.c sysctl net: Remove unused binary sysctl code 2009-11-12 02:05:06 -08:00
irttp.c net: irda: init spinlock after memcpy 2009-07-27 10:49:44 -07:00
Kconfig
Makefile
parameters.c
qos.c
timer.c
wrapper.c