OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
linux/drivers/phy
History
Tony Lindgren 7e1a0ec065 usb: phy: twl4030-usb: Fix regressions to runtime PM on omaps 
commit 96be39ab34 upstream.

Commit 30a70b026b ("usb: musb: fix obex in g_nokia.ko causing kernel
panic") attempted to fix runtime PM handling for PHYs that are on the
I2C bus. Commit 3063a12be2 ("usb: musb: fix PHY power on/off") then
changed things around to enable of PHYs that rely on runtime PM.

These changes however broke idling of the PHY and causes at least
100 mW extra power consumption on omaps, which is a lot with
the idle power consumption being below 10 mW range on many devices.

As calling phy_power_on/off from runtime PM calls in the USB
causes complicated issues with I2C connected PHYs, let's just let
the PHY do it's own runtime PM as needed. This leaves out the
dependency between PHYs and USB controller drivers for runtime
PM.

Let's fix the regression for twl4030-usb by adding minimal runtime
PM support. This allows idling the PHY on disconnect.

Note that we are changing to use standard runtime PM handling
for twl4030_phy_init() as that function just checks the state
and does not initialize the PHY. The PHY won't get initialized
until in twl4030_phy_power_on().

Fixes: 30a70b026b ("usb: musb: fix obex in g_nokia.ko causing kernel panic")
Fixes: 3063a12be2 ("usb: musb: fix PHY power on/off")
Acked-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 		2014-10-05 14:52:14 -07:00
..
Kconfig phy-core: Don't allow building phy-core as a module 2014-02-18 12:13:16 -08:00
Makefile USB patches for 3.14-rc1 2014-01-20 16:13:02 -08:00
phy-bcm-kona-usb2.c phy: add Broadcom Kona USB2 PHY driver 2013-12-23 14:33:02 -06:00
phy-core.c phy: core: Fix error path in phy_create() 2014-07-17 16:21:04 -07:00
phy-exynos-dp-video.c phy: let phy_provider_register be the last step in registering PHY 2014-02-18 12:13:16 -08:00
phy-exynos-mipi-video.c phy: exynos-mipi-video: fix check on array index 2014-06-30 20:11:52 -07:00
phy-mvebu-sata.c phy: let phy_provider_register be the last step in registering PHY 2014-02-18 12:13:16 -08:00
phy-omap-usb2.c phy: let phy_provider_register be the last step in registering PHY 2014-02-18 12:13:16 -08:00
phy-twl4030-usb.c usb: phy: twl4030-usb: Fix regressions to runtime PM on omaps 2014-10-05 14:52:14 -07:00