linux/net/netfilter/ipvs
Julian Anastasov 8a949fff03 ipvs: remove IPS_NAT_MASK check to fix passive FTP
The IPS_NAT_MASK check in 4.12 replaced previous check for nfct_nat()
which was needed to fix a crash in 2.6.36-rc, see
commit 7bcbf81a22 ("ipvs: avoid oops for passive FTP").
But as IPVS does not set the IPS_SRC_NAT and IPS_DST_NAT bits,
checking for IPS_NAT_MASK prevents PASV response to be properly
mangled and blocks the transfer. Remove the check as it is not
needed after 3.12 commit 41d73ec053 ("netfilter: nf_conntrack:
make sequence number adjustments usuable without NAT") which
changes nfct_nat() with nfct_seqadj() and especially after 3.13
commit b25adce160 ("ipvs: correct usage/allocation of seqadj
ext in ipvs").

Thanks to Li Shuang and Florian Westphal for reporting the problem!

Reported-by: Li Shuang <shuali@redhat.com>
Fixes: be7be6e161 ("netfilter: ipvs: fix incorrect conflict resolution")
Signed-off-by: Julian Anastasov <ja@ssi.bg>
Acked-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
2018-02-28 19:48:26 +01:00
..
Kconfig
Makefile
ip_vs_app.c netfilter: delete /proc THIS_MODULE references 2018-01-19 14:10:53 +01:00
ip_vs_conn.c netfilter: delete /proc THIS_MODULE references 2018-01-19 14:10:53 +01:00
ip_vs_core.c
ip_vs_ctl.c netfilter: delete /proc THIS_MODULE references 2018-01-19 14:10:53 +01:00
ip_vs_dh.c
ip_vs_est.c
ip_vs_fo.c
ip_vs_ftp.c ipvs: remove IPS_NAT_MASK check to fix passive FTP 2018-02-28 19:48:26 +01:00
ip_vs_lblc.c
ip_vs_lblcr.c
ip_vs_lc.c
ip_vs_nfct.c
ip_vs_nq.c
ip_vs_ovf.c
ip_vs_pe.c
ip_vs_pe_sip.c
ip_vs_proto.c
ip_vs_proto_ah_esp.c
ip_vs_proto_sctp.c
ip_vs_proto_tcp.c
ip_vs_proto_udp.c
ip_vs_rr.c
ip_vs_sched.c
ip_vs_sed.c
ip_vs_sh.c
ip_vs_sync.c
ip_vs_wlc.c
ip_vs_wrr.c
ip_vs_xmit.c