e2bde78713
Error handling code following a kmalloc should free the allocated data. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; statement S; expression E; identifier f,f1,l; position p1,p2; expression *ptr != NULL; @@ x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S <... when != x when != if (...) { <+...x...+> } ( x->f1 = E | (x->f1 == NULL || ...) | f(...,x->f1,...) ) ...> ( return \(0\|<+...x...+>\|ptr\); | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
193 lines
4.8 KiB
C
193 lines
4.8 KiB
C
/*
|
|
* DaVinci Voice Codec Core Interface for TI platforms
|
|
*
|
|
* Copyright (C) 2010 Texas Instruments, Inc
|
|
*
|
|
* Author: Miguel Aguilar <miguel.aguilar@ridgerun.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#include <linux/init.h>
|
|
#include <linux/module.h>
|
|
#include <linux/device.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/io.h>
|
|
#include <linux/clk.h>
|
|
|
|
#include <sound/pcm.h>
|
|
|
|
#include <linux/mfd/davinci_voicecodec.h>
|
|
|
|
u32 davinci_vc_read(struct davinci_vc *davinci_vc, int reg)
|
|
{
|
|
return __raw_readl(davinci_vc->base + reg);
|
|
}
|
|
|
|
void davinci_vc_write(struct davinci_vc *davinci_vc,
|
|
int reg, u32 val)
|
|
{
|
|
__raw_writel(val, davinci_vc->base + reg);
|
|
}
|
|
|
|
static int __init davinci_vc_probe(struct platform_device *pdev)
|
|
{
|
|
struct davinci_vc *davinci_vc;
|
|
struct resource *res, *mem;
|
|
struct mfd_cell *cell = NULL;
|
|
int ret;
|
|
|
|
davinci_vc = kzalloc(sizeof(struct davinci_vc), GFP_KERNEL);
|
|
if (!davinci_vc) {
|
|
dev_dbg(&pdev->dev,
|
|
"could not allocate memory for private data\n");
|
|
return -ENOMEM;
|
|
}
|
|
|
|
davinci_vc->clk = clk_get(&pdev->dev, NULL);
|
|
if (IS_ERR(davinci_vc->clk)) {
|
|
dev_dbg(&pdev->dev,
|
|
"could not get the clock for voice codec\n");
|
|
ret = -ENODEV;
|
|
goto fail1;
|
|
}
|
|
clk_enable(davinci_vc->clk);
|
|
|
|
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
if (!res) {
|
|
dev_err(&pdev->dev, "no mem resource\n");
|
|
ret = -ENODEV;
|
|
goto fail2;
|
|
}
|
|
|
|
davinci_vc->pbase = res->start;
|
|
davinci_vc->base_size = resource_size(res);
|
|
|
|
mem = request_mem_region(davinci_vc->pbase, davinci_vc->base_size,
|
|
pdev->name);
|
|
if (!mem) {
|
|
dev_err(&pdev->dev, "VCIF region already claimed\n");
|
|
ret = -EBUSY;
|
|
goto fail2;
|
|
}
|
|
|
|
davinci_vc->base = ioremap(davinci_vc->pbase, davinci_vc->base_size);
|
|
if (!davinci_vc->base) {
|
|
dev_err(&pdev->dev, "can't ioremap mem resource.\n");
|
|
ret = -ENOMEM;
|
|
goto fail3;
|
|
}
|
|
|
|
res = platform_get_resource(pdev, IORESOURCE_DMA, 0);
|
|
if (!res) {
|
|
dev_err(&pdev->dev, "no DMA resource\n");
|
|
ret = -ENXIO;
|
|
goto fail4;
|
|
}
|
|
|
|
davinci_vc->davinci_vcif.dma_tx_channel = res->start;
|
|
davinci_vc->davinci_vcif.dma_tx_addr =
|
|
(dma_addr_t)(io_v2p(davinci_vc->base) + DAVINCI_VC_WFIFO);
|
|
|
|
res = platform_get_resource(pdev, IORESOURCE_DMA, 1);
|
|
if (!res) {
|
|
dev_err(&pdev->dev, "no DMA resource\n");
|
|
ret = -ENXIO;
|
|
goto fail4;
|
|
}
|
|
|
|
davinci_vc->davinci_vcif.dma_rx_channel = res->start;
|
|
davinci_vc->davinci_vcif.dma_rx_addr =
|
|
(dma_addr_t)(io_v2p(davinci_vc->base) + DAVINCI_VC_RFIFO);
|
|
|
|
davinci_vc->dev = &pdev->dev;
|
|
davinci_vc->pdev = pdev;
|
|
|
|
/* Voice codec interface client */
|
|
cell = &davinci_vc->cells[DAVINCI_VC_VCIF_CELL];
|
|
cell->name = "davinci_vcif";
|
|
cell->driver_data = davinci_vc;
|
|
|
|
/* Voice codec CQ93VC client */
|
|
cell = &davinci_vc->cells[DAVINCI_VC_CQ93VC_CELL];
|
|
cell->name = "cq93vc";
|
|
cell->driver_data = davinci_vc;
|
|
|
|
ret = mfd_add_devices(&pdev->dev, pdev->id, davinci_vc->cells,
|
|
DAVINCI_VC_CELLS, NULL, 0);
|
|
if (ret != 0) {
|
|
dev_err(&pdev->dev, "fail to register client devices\n");
|
|
goto fail4;
|
|
}
|
|
|
|
return 0;
|
|
|
|
fail4:
|
|
iounmap(davinci_vc->base);
|
|
fail3:
|
|
release_mem_region(davinci_vc->pbase, davinci_vc->base_size);
|
|
fail2:
|
|
clk_disable(davinci_vc->clk);
|
|
clk_put(davinci_vc->clk);
|
|
davinci_vc->clk = NULL;
|
|
fail1:
|
|
kfree(davinci_vc);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int __devexit davinci_vc_remove(struct platform_device *pdev)
|
|
{
|
|
struct davinci_vc *davinci_vc = platform_get_drvdata(pdev);
|
|
|
|
mfd_remove_devices(&pdev->dev);
|
|
|
|
iounmap(davinci_vc->base);
|
|
release_mem_region(davinci_vc->pbase, davinci_vc->base_size);
|
|
|
|
clk_disable(davinci_vc->clk);
|
|
clk_put(davinci_vc->clk);
|
|
davinci_vc->clk = NULL;
|
|
|
|
kfree(davinci_vc);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct platform_driver davinci_vc_driver = {
|
|
.driver = {
|
|
.name = "davinci_voicecodec",
|
|
.owner = THIS_MODULE,
|
|
},
|
|
.remove = __devexit_p(davinci_vc_remove),
|
|
};
|
|
|
|
static int __init davinci_vc_init(void)
|
|
{
|
|
return platform_driver_probe(&davinci_vc_driver, davinci_vc_probe);
|
|
}
|
|
module_init(davinci_vc_init);
|
|
|
|
static void __exit davinci_vc_exit(void)
|
|
{
|
|
platform_driver_unregister(&davinci_vc_driver);
|
|
}
|
|
module_exit(davinci_vc_exit);
|
|
|
|
MODULE_AUTHOR("Miguel Aguilar");
|
|
MODULE_DESCRIPTION("Texas Instruments DaVinci Voice Codec Core Interface");
|
|
MODULE_LICENSE("GPL");
|