OpenE2K/linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
387178ec26
linux/drivers/video
History
Jean-Philippe Brucker a1e533ec07 fbcon: set a default value to blink interval 
Since commit 27a4c827c3
	fbcon: use the cursor blink interval provided by vt

two attempts have been made at fixing a possible hang caused by
cursor_timer_handler. That function registers a timer to be triggered at
"jiffies + fbcon_ops.cur_blink_jiffies".

A new case had been encountered during initialisation of clcd-pl11x:

    fbcon_fb_registered
    do_fbcon_takeover

    ->  do_register_con_driver
        fbcon_startup
    (A) add_cursor_timer (with cur_blink_jiffies = 0)

    ->  do_bind_con_driver
        visual_init
        fbcon_init
    (B) cur_blink_jiffies = msecs_to_jiffies(vc->vc_cur_blink_ms);

If we take an softirq anywhere between A and B (and we do),
cursor_timer_handler executes indefinitely.

Instead of patching all possible paths that lead to this case one at a
time, fix the issue at the source and initialise cur_blink_jiffies to
200ms when allocating fbcon_ops. This was its default value before
aforesaid commit. fbcon_cursor or fbcon_init will refine this value
downstream.

Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
Cc: <stable@vger.kernel.org> # v4.2
Tested-by: Scot Doyle <lkml14@scotdoyle.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
2016-02-26 13:19:55 +02:00
..
backlight backlight: pwm_bl: Free PWM requested by legacy API on error path 2016-01-11 10:45:24 +00:00
console fbcon: set a default value to blink interval 2016-02-26 13:19:55 +02:00
fbdev video: fbdev: imxfb: Provide a reset mechanism 2016-01-29 14:20:16 +02:00
logo video/logo: prevent use of logos after they have been freed 2014-12-29 10:06:55 +02:00
display_timing.c
hdmi.c [media] hdmi: rename HDMI_AUDIO_CODING_TYPE_EXT_STREAM to _EXT_CT 2015-01-27 10:19:12 -02:00
Kconfig drm: Remove two-level menu in Kconfig 2015-08-07 19:06:37 +02:00
Makefile video: move fbdev to drivers/video/fbdev 2014-04-17 08:10:19 +03:00
of_display_timing.c video: of: fix memory leak 2015-10-07 14:13:59 +03:00
of_videomode.c video: Fix possible leak in of_get_videomode() 2015-08-10 15:11:12 +03:00
vgastate.c fbdev: vgastate: remove trailing whitespaces 2015-01-13 12:53:25 +02:00
videomode.c