OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
linux/block
History
Ritesh Harjani 6736317f35 block: Set same_page to false in __bio_try_merge_page if ret is false 
[ Upstream commit 2cd896a5e8 ]

If we hit the UINT_MAX limit of bio->bi_iter.bi_size and so we are anyway
not merging this page in this bio, then it make sense to make same_page
also as false before returning.

Without this patch, we hit below WARNING in iomap.
This mostly happens with very large memory system and / or after tweaking
vm dirty threshold params to delay writeback of dirty data.

WARNING: CPU: 18 PID: 5130 at fs/iomap/buffered-io.c:74 iomap_page_release+0x120/0x150
 CPU: 18 PID: 5130 Comm: fio Kdump: loaded Tainted: G        W         5.8.0-rc3 #6
 Call Trace:
  __remove_mapping+0x154/0x320 (unreliable)
  iomap_releasepage+0x80/0x180
  try_to_release_page+0x94/0xe0
  invalidate_inode_page+0xc8/0x110
  invalidate_mapping_pages+0x1dc/0x540
  generic_fadvise+0x3c8/0x450
  xfs_file_fadvise+0x2c/0xe0 [xfs]
  vfs_fadvise+0x3c/0x60
  ksys_fadvise64_64+0x68/0xe0
  sys_fadvise64+0x28/0x40
  system_call_exception+0xf8/0x1c0
  system_call_common+0xf0/0x278

Fixes: cc90bc6842 ("block: fix "check bi_size overflow before merge"")
Reported-by: Shivaprasad G Bhat <sbhat@linux.ibm.com>
Suggested-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Anju T Sudhakar <anju@linux.vnet.ibm.com>
Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
 		2020-09-17 13:47:44 +02:00
..
partitions
…
Kconfig
…
Kconfig.iosched
…
Makefile
…
badblocks.c
…
bfq-cgroup.c bfq: fix blkio cgroup leakage v4 2020-09-03 11:26:54 +02:00
bfq-iosched.c
…
bfq-iosched.h bfq: fix blkio cgroup leakage v4 2020-09-03 11:26:54 +02:00
bfq-wf2q.c bfq: fix blkio cgroup leakage v4 2020-09-03 11:26:54 +02:00
bio-integrity.c
…
bio.c block: Set same_page to false in __bio_try_merge_page if ret is false 2020-09-17 13:47:44 +02:00
blk-cgroup.c blkcg: fix memleak for iolatency 2020-09-03 11:26:55 +02:00
blk-core.c block: ensure bdi->io_pages is always initialized 2020-09-09 19:12:34 +02:00
blk-exec.c
…
blk-flush.c
…
blk-integrity.c
…
blk-ioc.c
…
blk-iocost.c blk-iocost: ioc_pd_free() shouldn't assume irq disabled 2020-09-09 19:12:35 +02:00
blk-iolatency.c
…
blk-lib.c
…
blk-map.c
…
blk-merge.c block: fix get_max_io_size() 2020-09-03 11:27:01 +02:00
blk-mq-cpumap.c
…
blk-mq-debugfs-zoned.c
…
blk-mq-debugfs.c blk-mq-debugfs: update blk_queue_flag_name[] accordingly for new flags 2020-07-22 09:32:52 +02:00
blk-mq-debugfs.h
…
blk-mq-pci.c
…
blk-mq-rdma.c
…
blk-mq-sched.c blk-mq: order adding requests to hctx->dispatch and checking SCHED_RESTART 2020-09-03 11:27:01 +02:00
blk-mq-sched.h
…
blk-mq-sysfs.c
…
blk-mq-tag.c
…
blk-mq-tag.h
…
blk-mq-virtio.c
…
blk-mq.c blk-mq: order adding requests to hctx->dispatch and checking SCHED_RESTART 2020-09-03 11:27:01 +02:00
blk-mq.h
…
blk-pm.c
…
blk-pm.h
…
blk-rq-qos.c
…
blk-rq-qos.h
…
blk-settings.c
…
blk-softirq.c
…
blk-stat.c
…
blk-stat.h
…
blk-sysfs.c
…
blk-throttle.c
…
blk-timeout.c
…
blk-wbt.c
…
blk-wbt.h
…
blk-zoned.c
…
blk.h
…
bounce.c
…
bsg-lib.c
…
bsg.c
…
cmdline-parser.c
…
compat_ioctl.c
…
elevator.c
…
genhd.c
…
ioctl.c
…
ioprio.c
…
kyber-iosched.c
…
mq-deadline.c
…
opal_proto.h
…
partition-generic.c
…
scsi_ioctl.c
…
sed-opal.c
…
t10-pi.c
…