linux/drivers/crypto/chelsio
Eric Biggers 4f753389bc crypto: chelsio - fix writing tfm flags to wrong place
commit bd56cea012 upstream.

The chelsio crypto driver is casting 'struct crypto_aead' directly to
'struct crypto_tfm', which is incorrect because the crypto_tfm isn't the
first field of 'struct crypto_aead'.  Consequently, the calls to
crypto_tfm_set_flags() are modifying some other field in the struct.

Also, the driver is setting CRYPTO_TFM_RES_BAD_KEY_LEN in
->setauthsize(), not just in ->setkey().  This is incorrect since this
flag is for bad key lengths, not for bad authentication tag lengths.

Fix these bugs by removing the broken crypto_tfm_set_flags() calls from
->setauthsize() and by fixing them in ->setkey().

Fixes: 324429d741 ("chcr: Support for Chelsio's Crypto Hardware")
Cc: <stable@vger.kernel.org> # v4.9+
Cc: Atul Gupta <atul.gupta@chelsio.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-02-01 09:34:36 +00:00
..
chtls inet: stop leaking jiffies on the wire 2019-11-01 14:57:52 -07:00
Kconfig crypto: chelsio - replace AES cipher calls with library calls 2019-07-26 14:58:35 +10:00
Makefile
chcr_algo.c crypto: chelsio - fix writing tfm flags to wrong place 2020-02-01 09:34:36 +00:00
chcr_algo.h crypto: chelsio - Rename arrays to avoid conflict with crypto/sha256.h 2019-09-05 14:54:54 +10:00
chcr_core.c
chcr_core.h
chcr_crypto.h crypto: chelsio - replace AES cipher calls with library calls 2019-07-26 14:58:35 +10:00
chcr_ipsec.c crypto: chelsio - replace AES cipher calls with library calls 2019-07-26 14:58:35 +10:00