OpenE2K/linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
3eadf5f4f6
linux/net/tipc
History
Julia Lawall 4cec72c890 [TIPC]: Use tipc_port_unlock 
The file net/tipc/port.c takes a lock using the function tipc_port_lock and
then releases the lock sometimes using tipc_port_unlock and sometimes using
spin_unlock_bh(p_ptr->publ.lock).  tipc_port_unlock simply does the
spin_unlock_bh, but it seems cleaner to use it everywhere.

The problem was fixed using the following semantic patch.
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
struct port *p_ptr;
@@

   p_ptr = tipc_port_lock(...)
   ...
(
   p_ptr = tipc_port_lock(...);
|
?- spin_unlock_bh(p_ptr->publ.lock);
+  tipc_port_unlock(p_ptr);
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Jon Paul Maloy <maloy@donjonn.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-01-28 15:01:05 -08:00
..
addr.c [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
addr.h [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
bcast.c [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
bcast.h [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
bearer.c [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
bearer.h [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
cluster.c [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
cluster.h [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
config.c [SK_BUFF]: Convert skb->tail to sk_buff_data_t 2007-04-25 22:26:28 -07:00
config.h [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
core.c [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
core.h [NET]: Convert init_timer into setup_timer 2008-01-28 14:53:35 -08:00
dbg.c [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
dbg.h [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
discover.c [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
discover.h [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
eth_media.c [NET]: Wrap netdevice hardware header creation. 2007-10-10 16:52:50 -07:00
handler.c mm: Remove slab destructors from kmem_cache_create(). 2007-07-20 10:11:58 +09:00
Kconfig [TIPC]: Use menuconfig objects. 2007-05-24 16:36:50 -07:00
link.c [TIPC]: Fix two minor sparse warnings. 2007-08-02 19:42:31 -07:00
link.h [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
Makefile
msg.c [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
msg.h net/* misc endianness annotations 2007-07-26 11:11:56 -07:00
name_distr.c [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
name_distr.h [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
name_table.c [TIPC]: Make function tipc_nameseq_subscribe static. 2007-08-02 19:42:30 -07:00
name_table.h [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
net.c [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
net.h [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
netlink.c [TIPC]: Fix infinite loop in netlink handler 2007-06-23 22:59:40 -07:00
node_subscr.c [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
node_subscr.h [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
node.c [TIPC]: Fix two minor sparse warnings. 2007-08-02 19:42:31 -07:00
node.h [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
port.c [TIPC]: Use tipc_port_unlock 2008-01-28 15:01:05 -08:00
port.h [TIPC]: Optimize stream send routine to avoid fragmentation 2007-07-10 22:06:12 -07:00
ref.c [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
ref.h [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
socket.c [TIPC]: Fix semaphore handling. 2007-12-14 13:54:37 -08:00
subscr.c [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
subscr.h [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
user_reg.c [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
user_reg.h [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
zone.c [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00
zone.h [NET] TIPC: Fix whitespace errors. 2007-02-10 23:20:15 -08:00