linux/fs/xfs/linux-2.6
Christoph Lameter 50953fe9e0 slab allocators: Remove SLAB_DEBUG_INITIAL flag
I have never seen a use of SLAB_DEBUG_INITIAL.  It is only supported by
SLAB.

I think its purpose was to have a callback after an object has been freed
to verify that the state is the constructor state again?  The callback is
performed before each freeing of an object.

I would think that it is much easier to check the object state manually
before the free.  That also places the check near the code object
manipulation of the object.

Also the SLAB_DEBUG_INITIAL callback is only performed if the kernel was
compiled with SLAB debugging on.  If there would be code in a constructor
handling SLAB_DEBUG_INITIAL then it would have to be conditional on
SLAB_DEBUG otherwise it would just be dead code.  But there is no such code
in the kernel.  I think SLUB_DEBUG_INITIAL is too problematic to make real
use of, difficult to understand and there are easier ways to accomplish the
same effect (i.e.  add debug code before kfree).

There is a related flag SLAB_CTOR_VERIFY that is frequently checked to be
clear in fs inode caches.  Remove the pointless checks (they would even be
pointless without removeal of SLAB_DEBUG_INITIAL) from the fs constructors.

This is the last slab flag that SLUB did not support.  Remove the check for
unimplemented flags from SLUB.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-05-07 12:12:57 -07:00
..
kmem.c [PATCH] remove many unneeded #includes of sched.h 2007-02-14 08:09:54 -08:00
kmem.h [XFS] Add a greedy allocation interface, allocating within a min/max size 2006-09-28 11:03:27 +10:00
mrlock.h [XFS] mraccessf & mrupdatef are supposed to be the "flags" versions of the 2007-02-10 18:35:40 +11:00
mutex.h
sema.h [XFS] standardize on one sema init macro 2006-09-28 11:05:46 +10:00
spin.h
sv.h [XFS] Collapse sv_init and init_sv into just the one interface. 2006-09-28 11:05:52 +10:00
time.h
xfs_aops.c [PATCH] Make XFS use BH_Unwritten and BH_Delay correctly 2007-02-12 09:48:27 -08:00
xfs_aops.h
xfs_buf.c [PATCH] Make XFS workqueues nonfreezable 2007-03-22 19:39:06 -07:00
xfs_buf.h [XFS] Current usage of buftarg flags is incorrect. 2007-02-10 18:34:49 +11:00
xfs_cred.h
xfs_dmapi_priv.h [XFS] Remove KERNEL_VERSION macros from xfs_dmapi.h 2006-11-11 18:05:06 +11:00
xfs_export.c [XFS] Keep stack usage down for 4k stacks by using noinline. 2007-02-10 18:34:56 +11:00
xfs_export.h
xfs_file.c [XFS] Keep stack usage down for 4k stacks by using noinline. 2007-02-10 18:34:56 +11:00
xfs_fs_subr.c
xfs_fs_subr.h
xfs_globals.c [XFS] Improve error handling for the zero-fsblock extent detection code. 2006-09-28 11:03:20 +10:00
xfs_globals.h
xfs_ioctl.c [XFS] Remove unused header files for MAC and CAP checking functionality. 2007-02-10 18:37:28 +11:00
xfs_ioctl32.c [PATCH] xfs: change uses of f_{dentry,vfsmnt} to use f_path 2006-12-08 08:28:43 -08:00
xfs_ioctl32.h
xfs_iops.c [PATCH] mark struct inode_operations const 3 2007-02-12 09:48:46 -08:00
xfs_iops.h [PATCH] mark struct inode_operations const 3 2007-02-12 09:48:46 -08:00
xfs_linux.h [PATCH] Make BH_Unwritten a first class bufferhead flag V2 2007-02-12 09:48:27 -08:00
xfs_lrw.c [XFS] Don't use kmap in xfs_iozero. 2007-02-10 18:37:46 +11:00
xfs_lrw.h [XFS] Fix callers of xfs_iozero() to zero the correct range. 2007-02-10 18:36:47 +11:00
xfs_stats.c
xfs_stats.h
xfs_super.c slab allocators: Remove SLAB_DEBUG_INITIAL flag 2007-05-07 12:12:57 -07:00
xfs_super.h
xfs_sysctl.c [PATCH] sysctl: remove insert_at_head from register_sysctl 2007-02-14 08:09:59 -08:00
xfs_sysctl.h
xfs_version.h
xfs_vfs.c
xfs_vfs.h [XFS] Make freeze code a little cleaner. 2007-02-10 18:37:22 +11:00
xfs_vnode.c [XFS] Keep stack usage down for 4k stacks by using noinline. 2007-02-10 18:34:56 +11:00
xfs_vnode.h [XFS] Keep stack usage down for 4k stacks by using noinline. 2007-02-10 18:34:56 +11:00