4d5476164a
Our QA reported an oops in the ext4_mb_release_group_pa tracing, and Josef Bacik pointed out that it was because we may have a non-null but uninitialized ac_inode in the allocation context. I can reproduce it when running xfstests with ext4 tracepoints on, on a CONFIG_SLAB_DEBUG kernel. We call trace_ext4_mb_release_group_pa from 2 places, ext4_mb_discard_group_preallocations and ext4_mb_discard_lg_preallocations In both cases we allocate an ac as a container just for tracing (!) and never fill in the ac_inode. There's no reason to be assigning, testing, or printing it as far as I can see, so just remove it from the tracepoint. Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Josef Bacik <josef@redhat.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> |
||
---|---|---|
.. | ||
bkl.h | ||
block.h | ||
ext4.h | ||
gfpflags.h | ||
irq.h | ||
jbd2.h | ||
kmem.h | ||
kvm.h | ||
lock.h | ||
mce.h | ||
module.h | ||
napi.h | ||
power.h | ||
sched.h | ||
scsi.h | ||
signal.h | ||
skb.h | ||
syscalls.h | ||
timer.h | ||
vmscan.h | ||
workqueue.h | ||
writeback.h |