linux/drivers/staging/vc04_services
Phil Elwell ff92b9e3c9 staging: vc04_services: Fix bulk cache maintenance
vchiq_arm supports transfers less than one page and at arbitrary
alignment, using the dma-mapping API to perform its cache maintenance
(even though the VPU drives the DMA hardware). Read (DMA_FROM_DEVICE)
operations use cache invalidation for speed, falling back to
clean+invalidate on partial cache lines, with writes (DMA_TO_DEVICE)
using flushes.

If a read transfer has ends which aren't page-aligned, performing cache
maintenance as if they were whole pages can lead to memory corruption
since the partial cache lines at the ends (and any cache lines before or
after the transfer area) will be invalidated. This bug was masked until
the disabling of the cache flush in flush_dcache_page().

Honouring the requested transfer start- and end-points prevents the
corruption.

Fixes: cf9caf1929 ("staging: vc04_services: Replace dmac_map_area with dmac_map_sg")
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Cc: stable <stable@vger.kernel.org> # 4.10
Reported-by: Stefan Wahren <stefan.wahren@i2se.com>
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-05-15 11:48:44 +02:00
..
bcm2835-audio staging: bcm2835-audio: remove unnecessary log messages 2017-04-08 16:58:42 +02:00
bcm2835-camera staging: media/platform/bcm2835: remove gstreamer workaround 2017-04-18 13:54:24 +02:00
interface staging: vc04_services: Fix bulk cache maintenance 2017-05-15 11:48:44 +02:00
Kconfig Merge 4.11-rc4 into staging-next 2017-03-27 09:11:25 +02:00
Makefile staging: bcm2835-camera: Move driver under vc04_services 2017-03-06 09:17:07 +01:00