linux/drivers/scsi/lpfc
Arnd Bergmann aeb6641f8e lpfc: fix misleading indentation
gcc-6 complains about the indentation of the lpfc_destroy_vport_work_array()
call in lpfc_online(), which clearly doesn't look right:

drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_online':
drivers/scsi/lpfc/lpfc_init.c:2880:3: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation]
   lpfc_destroy_vport_work_array(phba, vports);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/lpfc/lpfc_init.c:2863:2: note: ...this 'if' clause, but it is not
  if (vports != NULL)
  ^~

Looking at the patch that introduced this code, it's clear that the
behavior is correct and the indentation is wrong.

This fixes the indentation and adds curly braces around the previous
if() block for clarity, as that is most likely what caused the code
to be misindented in the first place.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 549e55cd2a ("[SCSI] lpfc 8.2.2 : Fix locking around HBA's port_list")
Reviewed-by: Sebastian Herbszt <herbszt@gmx.de>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2016-03-18 15:21:23 -04:00
..
Makefile
lpfc.h
lpfc_attr.c lpfc: Use new FDMI speed definitions for 10G, 25G and 40G FCoE. 2015-12-21 22:04:04 -05:00
lpfc_bsg.c
lpfc_bsg.h
lpfc_compat.h
lpfc_crtn.h
lpfc_ct.c lpfc: Use new FDMI speed definitions for 10G, 25G and 40G FCoE. 2015-12-21 22:04:04 -05:00
lpfc_debugfs.c lpfc: fix missing zero termination in debugfs 2016-02-23 21:27:02 -05:00
lpfc_debugfs.h
lpfc_disc.h
lpfc_els.c lpfc: Use kzalloc instead of kmalloc 2015-12-21 22:08:15 -05:00
lpfc_hbadisc.c lpfc: Add lockdep assertions 2016-02-23 21:27:02 -05:00
lpfc_hw.h
lpfc_hw4.h lpfc: Add logging for misconfigured optics. 2015-12-21 22:06:09 -05:00
lpfc_init.c lpfc: fix misleading indentation 2016-03-18 15:21:23 -04:00
lpfc_logmsg.h
lpfc_mbox.c
lpfc_mem.c lpfc: Delete unnecessary checks before the function call "mempool_destroy" 2015-12-21 22:06:36 -05:00
lpfc_nl.h
lpfc_nportdisc.c lpfc: Fix mbox reuse in PLOGI completion 2015-12-21 22:04:33 -05:00
lpfc_scsi.c lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl 2016-02-23 21:27:02 -05:00
lpfc_scsi.h
lpfc_sli.c lpfc: Add lockdep assertions 2016-02-23 21:27:02 -05:00
lpfc_sli.h
lpfc_sli4.h lpfc: Add logging for misconfigured optics. 2015-12-21 22:06:09 -05:00
lpfc_version.h lpfc: Update version to 11.0.0.10 for upstream patch set 2015-12-21 22:08:49 -05:00
lpfc_vport.c
lpfc_vport.h