linux/arch/powerpc
Andrea Righi 27ac792ca0 PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures
On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit
boundary. For example:

	u64 val = PAGE_ALIGN(size);

always returns a value < 4GB even if size is greater than 4GB.

The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for
example):

#define PAGE_SHIFT      12
#define PAGE_SIZE       (_AC(1,UL) << PAGE_SHIFT)
#define PAGE_MASK       (~(PAGE_SIZE-1))
...
#define PAGE_ALIGN(addr)       (((addr)+PAGE_SIZE-1)&PAGE_MASK)

The "~" is performed on a 32-bit value, so everything in "and" with
PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary.
Using the ALIGN() macro seems to be the right way, because it uses
typeof(addr) for the mask.

Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in
include/linux/mm.h.

See also lkml discussion: http://lkml.org/lkml/2008/6/11/237

[akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c]
[akpm@linux-foundation.org: fix v850]
[akpm@linux-foundation.org: fix powerpc]
[akpm@linux-foundation.org: fix arm]
[akpm@linux-foundation.org: fix mips]
[akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c]
[akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c]
[akpm@linux-foundation.org: fix powerpc]
Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
Cc: <linux-arch@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-24 10:47:21 -07:00
..
boot powerpc/boot: Change spaces to tabs 2008-07-22 10:39:35 +10:00
configs powerpc/ps3: Update ps3_defconfig 2008-07-22 10:39:33 +10:00
kernel PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures 2008-07-24 10:47:21 -07:00
kvm KVM: MMU: nuke shadowed pgtable pages and ptes on memslot destruction 2008-07-20 12:42:40 +03:00
lib PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures 2008-07-24 10:47:21 -07:00
math-emu powerpc: Add macros to access floating point registers in thread_struct. 2008-07-01 11:28:43 +10:00
mm powerpc: support multiple hugepage sizes 2008-07-24 10:47:19 -07:00
oprofile on_each_cpu(): kill unused 'retry' parameter 2008-06-26 11:24:38 +02:00
platforms spufs: use new vm_ops->access to allow local state access from gdb 2008-07-24 10:47:15 -07:00
sysdev powerpc/dma: Use the struct dma_attrs in iommu code 2008-07-22 10:39:32 +10:00
xmon Merge branch 'linux-2.6' 2008-06-30 10:16:50 +10:00
.gitignore [POWERPC] Add files build to .gitignore 2006-12-04 20:41:29 +11:00
Kconfig powerpc ioremap_prot 2008-07-24 10:47:15 -07:00
Kconfig.debug kgdb, powerpc: arch specific powerpc kgdb support 2008-07-23 11:30:15 -05:00
Makefile powerpc/bootwrapper: Add documentation of boot wrapper targets 2008-07-04 00:59:03 -06:00