linux/fs/affs
Navid Emamdoost 6bdc0eab88 affs: fix a memory leak in affs_remount
commit 450c3d4166 upstream.

In affs_remount if data is provided it is duplicated into new_opts.  The
allocated memory for new_opts is only released if parse_options fails.

There's a bit of history behind new_options, originally there was
save/replace options on the VFS layer so the 'data' passed must not
change (thus strdup), this got cleaned up in later patches. But not
completely.

There's no reason to do the strdup in cases where the filesystem does
not need to reuse the 'data' again, because strsep would modify it
directly.

Fixes: c8f33d0bec ("affs: kstrdup() memory handling")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
[ update changelog ]
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-01-17 19:48:50 +01:00
..
Changes
Kconfig
Makefile
affs.h
amigaffs.c fs: affs: Initialize filesystem timestamp ranges 2019-08-30 07:27:18 -07:00
amigaffs.h fs: affs: Initialize filesystem timestamp ranges 2019-08-30 07:27:18 -07:00
bitmap.c
dir.c
file.c
inode.c fs: affs: Initialize filesystem timestamp ranges 2019-08-30 07:27:18 -07:00
namei.c
super.c affs: fix a memory leak in affs_remount 2020-01-17 19:48:50 +01:00
symlink.c