5dd7ed2e81
This patch addresses the majority of sparse warnings and adds proper locking annotations. It also fixes the dubious one-bit signed bitfield, for which the signed one-bit types can be 0 or -1 which can cause a problem if someone ever checks if (foo->lu_gp_assoc == 1). The current code is fine because everyone just checks zero vs non-zero. But Sparse complains about it so lets change it. The warnings look like this: include/target/target_core_base.h:228:26: error: dubious one-bit signed bitfield Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Fubo Chen <fubo.chen@gmail.com> Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org> Signed-off-by: James Bottomley <James.Bottomley@suse.de> |
||
|---|---|---|
| .. | ||
| configfs_macros.h | ||
| target_core_base.h | ||
| target_core_configfs.h | ||
| target_core_device.h | ||
| target_core_fabric_configfs.h | ||
| target_core_fabric_lib.h | ||
| target_core_fabric_ops.h | ||
| target_core_tmr.h | ||
| target_core_tpg.h | ||
| target_core_transport.h | ||