linux/net/sunrpc
Christoph Lameter 50953fe9e0 slab allocators: Remove SLAB_DEBUG_INITIAL flag
I have never seen a use of SLAB_DEBUG_INITIAL.  It is only supported by
SLAB.

I think its purpose was to have a callback after an object has been freed
to verify that the state is the constructor state again?  The callback is
performed before each freeing of an object.

I would think that it is much easier to check the object state manually
before the free.  That also places the check near the code object
manipulation of the object.

Also the SLAB_DEBUG_INITIAL callback is only performed if the kernel was
compiled with SLAB debugging on.  If there would be code in a constructor
handling SLAB_DEBUG_INITIAL then it would have to be conditional on
SLAB_DEBUG otherwise it would just be dead code.  But there is no such code
in the kernel.  I think SLUB_DEBUG_INITIAL is too problematic to make real
use of, difficult to understand and there are easier ways to accomplish the
same effect (i.e.  add debug code before kfree).

There is a related flag SLAB_CTOR_VERIFY that is frequently checked to be
clear in fs inode caches.  Remove the pointless checks (they would even be
pointless without removeal of SLAB_DEBUG_INITIAL) from the fs constructors.

This is the last slab flag that SLUB did not support.  Remove the check for
unimplemented flags from SLUB.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-05-07 12:12:57 -07:00
..
auth_gss spkm3: initialize hash 2007-05-02 07:37:07 -07:00
Makefile SUNRPC: remove old portmapper 2007-04-30 22:17:15 -07:00
auth.c Merge branch 'master' of /home/trondmy/kernel/linux-2.6/ 2007-02-12 22:43:25 -08:00
auth_null.c [PATCH] remove many unneeded #includes of sched.h 2007-02-14 08:09:54 -08:00
auth_unix.c SUNRPC: fix print format for tk_pid 2007-02-03 15:35:10 -08:00
cache.c [SUNRPC]: cleanup: use seq_release_private() where appropriate 2007-04-26 01:03:43 -07:00
clnt.c SUNRPC: RPC client should retry with different versions of rpcbind 2007-04-30 22:17:16 -07:00
rpc_pipe.c slab allocators: Remove SLAB_DEBUG_INITIAL flag 2007-05-07 12:12:57 -07:00
rpcb_clnt.c SUNRPC: introduce rpcbind: replacement for in-kernel portmapper 2007-04-30 22:17:12 -07:00
sched.c SUNRPC: Eliminate side effects from rpc_malloc 2007-04-30 22:17:11 -07:00
socklib.c [NET]: Treat CHECKSUM_PARTIAL as CHECKSUM_UNNECESSARY 2007-04-25 22:28:43 -07:00
stats.c [PATCH] remove many unneeded #includes of sched.h 2007-02-14 08:09:54 -08:00
sunrpc_syms.c [PATCH] remove many unneeded #includes of sched.h 2007-02-14 08:09:54 -08:00
svc.c SUNRPC: switch the RPC server to use the new rpcbind registration API 2007-04-30 22:17:13 -07:00
svcauth.c [PATCH] remove many unneeded #includes of sched.h 2007-02-14 08:09:54 -08:00
svcauth_unix.c knfsd: use a spinlock to protect sk_info_authunix 2007-04-17 16:36:27 -07:00
svcsock.c [NET]: convert network timestamps to ktime_t 2007-04-25 22:23:34 -07:00
sysctl.c [PATCH] sysctl: remove insert_at_head from register_sysctl 2007-02-14 08:09:59 -08:00
timer.c
xdr.c [NET] SUNRPC: Fix whitespace errors. 2007-02-10 23:20:13 -08:00
xprt.c SUNRPC: introduce rpcbind: replacement for in-kernel portmapper 2007-04-30 22:17:12 -07:00
xprtsock.c SUNRPC: switch socket-based RPC transports to use rpcbind 2007-04-30 22:17:13 -07:00