linux/drivers/isdn
Johannes Berg 634fef6107 networking: add and use skb_put_u8()
Joe and Bjørn suggested that it'd be nicer to not have the
cast in the fairly common case of doing
	*(u8 *)skb_put(skb, 1) = c;

Add skb_put_u8() for this case, and use it across the code,
using the following spatch:

    @@
    expression SKB, C, S;
    typedef u8;
    identifier fn = {skb_put};
    fresh identifier fn2 = fn ## "_u8";
    @@
    - *(u8 *)fn(SKB, S) = C;
    + fn2(SKB, C);

Note that due to the "S", the spatch isn't perfect, it should
have checked that S is 1, but there's also places that use a
sizeof expression like sizeof(var) or sizeof(u8) etc. Turns
out that nobody ever did something like
	*(u8 *)skb_put(skb, 2) = c;

which would be wrong anyway since the second byte wouldn't be
initialized.

Suggested-by: Joe Perches <joe@perches.com>
Suggested-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-16 11:48:40 -04:00
..
capi networking: add and use skb_put_u8() 2017-06-16 11:48:40 -04:00
divert isdn: use setup_timer 2017-03-24 12:33:42 -07:00
gigaset networking: add and use skb_put_u8() 2017-06-16 11:48:40 -04:00
hardware networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
hisax networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
hysdn networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
i4l networking: add and use skb_put_u8() 2017-06-16 11:48:40 -04:00
isdnloop networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
mISDN networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
Kconfig tty: Added a CONFIG_TTY option to allow removal of TTY 2013-01-18 16:15:27 -08:00
Makefile isdn: i4l: move active-isdn drivers to staging 2016-03-05 15:00:38 -08:00