linux/drivers/isdn/sc
Dan Carpenter b530fb69cf isdn: strcpy() => strlcpy()
setup.phone and setup.eazmsn are 32 character buffers.
rcvmsg.msg_data.byte_array is a 48 character buffer.
sc_adapter[card]->channel[rcvmsg.phy_link_no - 1].dn is 50 chars.

The rcvmsg struct comes from the memcpy_fromio() in receivemessage().
I guess that means it's data off the wire.  I'm not very familiar with
this code but I don't see any reason to assume these strings are NULL
terminated.

Also it's weird that "dn" in a 50 character buffer but we only seem to
use 32 characters.  In drivers/isdn/sc/scioc.h, "dn" is only a 49
character buffer.  So potentially there is still an issue there.

The important thing for now is to prevent the memory corruption.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2010-10-08 10:21:22 -07:00
..
Kconfig Kconfig: Remove useless and sometimes wrong comments 2009-11-09 09:40:56 +01:00
Makefile
card.h [ISDN] sc: Fix sndpkt to have the correct number of arguments 2007-11-14 15:57:38 -08:00
command.c isdn/sc: compile breakage re check_reset() 2007-07-19 10:04:50 -07:00
event.c [PATCH] drivers/isdn/sc/: proper prototypes 2007-02-12 09:48:34 -08:00
hardware.h tree-wide: fix typos "ammount" -> "amount" 2010-02-05 12:22:40 +01:00
includes.h isdn/sc: remove unused REQUEST_IRQ and unnecessary header file 2007-10-19 11:53:34 -07:00
init.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
interrupt.c isdn: strcpy() => strlcpy() 2010-10-08 10:21:22 -07:00
ioctl.c isdn: fix information leak 2010-08-05 13:21:25 -07:00
message.c Detach sched.h from mm.h 2007-05-21 09:18:19 -07:00
message.h
packet.c [ISDN] sc: Fix sndpkt to have the correct number of arguments 2007-11-14 15:57:38 -08:00
scioc.h [PATCH] drivers/isdn/sc/: proper prototypes 2007-02-12 09:48:34 -08:00
shmem.c ISDN: fix sc/shmem printk format warning 2009-02-20 00:54:44 -08:00
timer.c isdn/sc: compile breakage re check_reset() 2007-07-19 10:04:50 -07:00