OpenE2K
/
linux
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
linux/drivers/iio/imu
History
Stephan Gerhold 8e5164949a iio: imu: st_lsm6dsx: Fix selection of ST_LSM6DS3_ID 
commit fb4fbc8904 upstream.

At the moment, attempting to probe a device with ST_LSM6DS3_ID
(e.g. using the st,lsm6ds3 compatible) fails with:

    st_lsm6dsx_i2c 1-006b: unsupported whoami [69]

... even though 0x69 is the whoami listed for ST_LSM6DS3_ID.

This happens because st_lsm6dsx_check_whoami() also attempts
to match unspecified (zero-initialized) entries in the "id" array.
ST_LSM6DS3_ID = 0 will therefore match any entry in
st_lsm6dsx_sensor_settings (here: the first), because none of them
actually have all 12 entries listed in the "id" array.

Avoid this by additionally checking if "name" is set,
which is only set for valid entries in the "id" array.

Note: Although the problem was introduced earlier it did not surface until
commit 52f4b1f196 ("iio: imu: st_lsm6dsx: add support for accel/gyro unit of lsm9ds1")
because ST_LSM6DS3_ID was the first entry in st_lsm6dsx_sensor_settings.

Fixes: d068e4a0f9 ("iio: imu: st_lsm6dsx: add support to multiple devices with the same settings")
Cc: <stable@vger.kernel.org> # 5.4
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 		2020-01-23 08:22:33 +01:00
..
bmi160 treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
inv_mpu6050 iio: imu: inv_mpu6050: fix temperature reporting using bad unit 2019-12-17 19:55:42 +01:00
st_lsm6dsx iio: imu: st_lsm6dsx: Fix selection of ST_LSM6DS3_ID 2020-01-23 08:22:33 +01:00
Kconfig iio: imu: Add support for the ADIS16460 IMU 2019-07-27 22:52:06 +01:00
Makefile iio: imu: Add support for the ADIS16460 IMU 2019-07-27 22:52:06 +01:00
adis.c iio: imu: adis: Add support for SPI transfer cs_change_delay 2019-07-27 22:52:06 +01:00
adis16400.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
adis16460.c iio: imu: adis16460: fix variable signedness 2019-08-18 18:53:15 +01:00
adis16480.c iio: imu: adis16480: assign bias value only if operation succeeded 2020-01-17 19:48:48 +01:00
adis_buffer.c iio: imu: adis16400: fix memory leak 2019-10-09 19:11:27 +01:00
adis_trigger.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 149 2019-05-30 11:25:18 -07:00
kmx61.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 330 2019-06-05 17:37:06 +02:00