0a54b809a3
When building with C=2 and/or W=1, legitimate warnings are issued about
missing prototypes:
CHECK drivers/ras/debugfs.c
drivers/ras/debugfs.c:4:15: warning: symbol 'ras_debugfs_dir' was not declared. Should it be static?
drivers/ras/debugfs.c:8:5: warning: symbol 'ras_userspace_consumers' was not declared. Should it be static?
drivers/ras/debugfs.c:38:12: warning: symbol 'ras_add_daemon_trace' was not declared. Should it be static?
drivers/ras/debugfs.c:54:13: warning: symbol 'ras_debugfs_init' was not declared. Should it be static?
CC drivers/ras/debugfs.o
drivers/ras/debugfs.c:8:5: warning: no previous prototype for 'ras_userspace_consumers' [-Wmissing-prototypes]
8 | int ras_userspace_consumers(void)
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/ras/debugfs.c:38:12: warning: no previous prototype for 'ras_add_daemon_trace' [-Wmissing-prototypes]
38 | int __init ras_add_daemon_trace(void)
| ^~~~~~~~~~~~~~~~~~~~
drivers/ras/debugfs.c:54:13: warning: no previous prototype for 'ras_debugfs_init' [-Wmissing-prototypes]
54 | void __init ras_debugfs_init(void)
| ^~~~~~~~~~~~~~~~
Provide the proper includes.
[ bp: Take care of the same warnings for cec.c too. ]
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: linux-edac@vger.kernel.org
Cc: x86@kernel.org
Link: http://lkml.kernel.org/r/7168.1565218769@turing-police
60 lines
1.1 KiB
C
60 lines
1.1 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
#include <linux/debugfs.h>
|
|
#include <linux/ras.h>
|
|
#include "debugfs.h"
|
|
|
|
struct dentry *ras_debugfs_dir;
|
|
|
|
static atomic_t trace_count = ATOMIC_INIT(0);
|
|
|
|
int ras_userspace_consumers(void)
|
|
{
|
|
return atomic_read(&trace_count);
|
|
}
|
|
EXPORT_SYMBOL_GPL(ras_userspace_consumers);
|
|
|
|
static int trace_show(struct seq_file *m, void *v)
|
|
{
|
|
return atomic_read(&trace_count);
|
|
}
|
|
|
|
static int trace_open(struct inode *inode, struct file *file)
|
|
{
|
|
atomic_inc(&trace_count);
|
|
return single_open(file, trace_show, NULL);
|
|
}
|
|
|
|
static int trace_release(struct inode *inode, struct file *file)
|
|
{
|
|
atomic_dec(&trace_count);
|
|
return single_release(inode, file);
|
|
}
|
|
|
|
static const struct file_operations trace_fops = {
|
|
.open = trace_open,
|
|
.read = seq_read,
|
|
.llseek = seq_lseek,
|
|
.release = trace_release,
|
|
};
|
|
|
|
int __init ras_add_daemon_trace(void)
|
|
{
|
|
struct dentry *fentry;
|
|
|
|
if (!ras_debugfs_dir)
|
|
return -ENOENT;
|
|
|
|
fentry = debugfs_create_file("daemon_active", S_IRUSR, ras_debugfs_dir,
|
|
NULL, &trace_fops);
|
|
if (!fentry)
|
|
return -ENODEV;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
void __init ras_debugfs_init(void)
|
|
{
|
|
ras_debugfs_dir = debugfs_create_dir("ras", NULL);
|
|
}
|