linux/fs/lockd
J. Bruce Fields 89996df4b5 lockd: fix list corruption on lockd restart
If lockd is signalled soon enough after restart then locks_start_grace()
will try to re-add an entry to a list and trigger a lock corruption
warning.

Thanks to Wang Chen for the problem report and diagnosis.

WARNING: at lib/list_debug.c:26 __list_add+0x27/0x5c()
...
list_add corruption. next->prev should be prev (ef8fe958), but was ef8ff128.  (next=ef8ff128).
...
Pid: 23062, comm: lockd Tainted: G        W  2.6.30-rc2 #3
Call Trace:
[<c042d5b5>] warn_slowpath+0x71/0xa0
[<c0422a96>] ? update_curr+0x11d/0x125
[<c044b12d>] ? trace_hardirqs_on_caller+0x18/0x150
[<c044b270>] ? trace_hardirqs_on+0xb/0xd
[<c051c61a>] ? _raw_spin_lock+0x53/0xfa
[<c051c89f>] __list_add+0x27/0x5c
[<ef8f6daa>] locks_start_grace+0x22/0x30 [lockd]
[<ef8f34da>] set_grace_period+0x39/0x53 [lockd]
[<c06b8921>] ? lock_kernel+0x1c/0x28
[<ef8f3558>] lockd+0x64/0x164 [lockd]
[<c044b12d>] ? trace_hardirqs_on_caller+0x18/0x150
[<c04227b0>] ? complete+0x34/0x3e
[<ef8f34f4>] ? lockd+0x0/0x164 [lockd]
[<ef8f34f4>] ? lockd+0x0/0x164 [lockd]
[<c043dd42>] kthread+0x45/0x6b
[<c043dcfd>] ? kthread+0x0/0x6b
[<c0403c23>] kernel_thread_helper+0x7/0x10

Reported-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Cc: stable@kernel.org
2009-05-06 17:19:36 -04:00
..
Makefile nfsd: common grace period control 2008-10-03 16:19:02 -04:00
clntlock.c lockd: Start PF_INET6 listener only if IPv6 support is available 2009-03-28 16:01:16 -04:00
clntproc.c NSM: Remove include/linux/lockd/sm_inter.h 2009-01-06 11:53:55 -05:00
grace.c nfsd: common grace period control 2008-10-03 16:19:02 -04:00
host.c NSM: Remove include/linux/lockd/sm_inter.h 2009-01-06 11:53:55 -05:00
mon.c NSM: Fix unaligned accesses in nsm_init_private() 2009-04-01 13:24:14 -04:00
svc.c lockd: fix list corruption on lockd restart 2009-05-06 17:19:36 -04:00
svc4proc.c NSM: Remove include/linux/lockd/sm_inter.h 2009-01-06 11:53:55 -05:00
svclock.c lockd: clean up blocking lock cases of nlsmvc_lock() 2009-03-18 17:30:50 -04:00
svcproc.c NSM: Remove include/linux/lockd/sm_inter.h 2009-01-06 11:53:55 -05:00
svcshare.c lockd: fix sparse warning in svcshare.c 2008-04-23 16:13:39 -04:00
svcsubs.c NSM: Remove include/linux/lockd/sm_inter.h 2009-01-06 11:53:55 -05:00
xdr.c NSM: Remove include/linux/lockd/sm_inter.h 2009-01-06 11:53:55 -05:00
xdr4.c NSM: Remove include/linux/lockd/sm_inter.h 2009-01-06 11:53:55 -05:00