linux/drivers/pinctrl/freescale
Tony Lindgren 950b0d91dc pinctrl: core: Fix regression caused by delayed work for hogs
Commit df61b366af26 ("pinctrl: core: Use delayed work for hogs") caused a
regression at least with sh-pfc that is also a GPIO controller as
noted by Geert Uytterhoeven <geert@linux-m68k.org>.

As the original pinctrl_register() has issues calling pin controller
driver functions early before the controller has finished registering,
we can't just revert commit df61b366af26. That would break the drivers
using GENERIC_PINCTRL_GROUPS or GENERIC_PINMUX_FUNCTIONS.

So let's fix the issue with the following steps as a single patch:

1. Revert the late_init parts of commit df61b366af26.

   The late_init clearly won't work and we have to just give up
   on fixing pinctrl_register() for GENERIC_PINCTRL_GROUPS and
   GENERIC_PINMUX_FUNCTIONS.

2. Split pinctrl_register() into two parts

   By splitting pinctrl_register() into pinctrl_init_controller()
   and pinctrl_create_and_start() we have better control over when
   it's safe to call pinctrl_create().

3. Introduce a new pinctrl_register_and_init() function

   As suggested by Linus Walleij <linus.walleij@linaro.org>, we
   can just introduce a new function for the controllers that need
   pinctrl_create() called later.

4. Convert the four known problem cases to use new function

   Let's convert pinctrl-imx, pinctrl-single, sh-pfc and ti-iodelay
   to use the new function to fix the issues. The rest of the drivers
   can be converted later. Let's also update Documentation/pinctrl.txt
   accordingly because of the known issues with pinctrl_register().

Fixes: df61b366af26 ("pinctrl: core: Use delayed work for hogs")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Gary Bisson <gary.bisson@boundarydevices.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
2017-01-13 16:25:17 +01:00
..
Kconfig pinctrl: imx: use generic pinmux helpers for managing functions 2017-01-03 09:26:21 +01:00
Makefile pinctrl: imx: add i.mx6ul subdriver 2015-07-16 09:39:02 +02:00
pinctrl-imx.c pinctrl: core: Fix regression caused by delayed work for hogs 2017-01-13 16:25:17 +01:00
pinctrl-imx.h pinctrl: imx: use generic pinmux helpers for managing functions 2017-01-03 09:26:21 +01:00
pinctrl-imx1-core.c pinctrl: freescale: remove needless module.h include 2016-06-29 09:30:10 +02:00
pinctrl-imx1.c pinctrl: imx1: make it explicitly non-modular 2016-06-29 09:31:03 +02:00
pinctrl-imx1.h pinctrl: imxl: Use devm_pinctrl_register() for pinctrl registration 2016-04-21 00:02:21 +02:00
pinctrl-imx6dl.c pinctrl: imx6dl: make it explicitly non-modular 2016-06-29 09:38:40 +02:00
pinctrl-imx6q.c pinctrl: imx6q: make it explicitly non-modular 2016-06-29 09:49:20 +02:00
pinctrl-imx6sl.c pinctrl: imx6sl: make it explicitly non-modular 2016-06-29 09:50:10 +02:00
pinctrl-imx6sx.c pinctrl: imx6sx: make it explicitly non-modular 2016-06-29 09:51:08 +02:00
pinctrl-imx6ul.c pinctrl: imx6ul: make it explicitly non-modular 2016-06-29 09:52:01 +02:00
pinctrl-imx7d.c pinctrl: imx7d: make it explicitly non-modular 2016-06-29 09:52:59 +02:00
pinctrl-imx21.c pinctrl: imx21: Remove the MODULE_DEVICE_TABLE() macro 2016-07-06 15:41:31 +02:00
pinctrl-imx23.c pinctrl: imx23: make it explicitly non-modular 2016-06-29 09:54:37 +02:00
pinctrl-imx25.c pinctrl: imx25: make it explicitly non-modular 2016-06-29 09:32:59 +02:00
pinctrl-imx27.c pinctrl: imx27: make it explicitly non-modular 2016-06-29 09:34:01 +02:00
pinctrl-imx28.c pinctrl: imx28: make it explicitly non-modular 2016-06-29 09:55:30 +02:00
pinctrl-imx35.c pinctrl: imx35: make it explicitly non-modular 2016-06-29 09:34:52 +02:00
pinctrl-imx50.c pinctrl: imx50: make it explicitly non-modular 2016-06-29 09:35:48 +02:00
pinctrl-imx51.c pinctrl: imx51: make it explicitly non-modular 2016-06-29 09:36:53 +02:00
pinctrl-imx53.c pinctrl: imx53: make it explicitly non-modular 2016-06-29 09:37:44 +02:00
pinctrl-mxs.c pinctrl: remove orphaned exported ".remove" function 2016-06-29 09:56:28 +02:00
pinctrl-mxs.h pinctrl: remove orphaned exported ".remove" function 2016-06-29 09:56:28 +02:00
pinctrl-vf610.c pinctrl: vf610: make it explicitly non-modular 2016-06-29 09:53:48 +02:00