linux/drivers/firmware
Matt Fleming e504a78c93 efi: Pass correct file handle to efi_file_{read,close}
commit 47514c996f upstream.

We're currently passing the file handle for the root file system to
efi_file_read() and efi_file_close(), instead of the file handle for the
file we wish to read/close.

While this has worked up until now, it seems that it has only been by
pure luck. Olivier explains,

 "The issue is the UEFI Fat driver might return the same function for
  'fh->read()' and 'h->read()'. While in our case it does not work with
  a different implementation of EFI_SIMPLE_FILE_SYSTEM_PROTOCOL. In our
  case, we return a different pointer when reading a directory and
  reading a file."

Fixing this actually clears up the two functions because we can drop one
of the arguments, and instead only pass a file 'handle' argument.

Reported-by: Olivier Martin <olivier.martin@arm.com>
Reviewed-by: Olivier Martin <olivier.martin@arm.com>
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-06 07:59:29 -07:00
..
efi efi: Pass correct file handle to efi_file_{read,close} 2014-05-06 07:59:29 -07:00
google firmware/google: drop 'select EFI' to avoid recursive dependency 2014-01-27 21:02:40 -08:00
dcdbas.c
dcdbas.h
dell_rbu.c
dmi_scan.c firmware/dmi_scan: generalize for use by other archs 2014-01-23 16:36:57 -08:00
dmi-id.c
dmi-sysfs.c firmware: dmi-sysfs: Remove "dmi" directory on module exit 2013-12-08 18:23:42 -08:00
edd.c
iscsi_ibft_find.c
iscsi_ibft.c
Kconfig ACPI and power management updates for 3.14-rc1 2014-01-24 15:51:02 -08:00
Makefile x86/efi: Don't select EFI from certain special ACPI drivers 2013-12-19 21:32:46 +01:00
memmap.c drivers/firmware/memmap.c: use memblock apis for early memory allocations 2014-01-21 16:19:47 -08:00
pcdp.c
pcdp.h