linux/drivers/mtd
Andrea Righi 27ac792ca0 PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures
On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit
boundary. For example:

	u64 val = PAGE_ALIGN(size);

always returns a value < 4GB even if size is greater than 4GB.

The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for
example):

#define PAGE_SHIFT      12
#define PAGE_SIZE       (_AC(1,UL) << PAGE_SHIFT)
#define PAGE_MASK       (~(PAGE_SIZE-1))
...
#define PAGE_ALIGN(addr)       (((addr)+PAGE_SIZE-1)&PAGE_MASK)

The "~" is performed on a 32-bit value, so everything in "and" with
PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary.
Using the ALIGN() macro seems to be the right way, because it uses
typeof(addr) for the mask.

Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in
include/linux/mm.h.

See also lkml discussion: http://lkml.org/lkml/2008/6/11/237

[akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c]
[akpm@linux-foundation.org: fix v850]
[akpm@linux-foundation.org: fix powerpc]
[akpm@linux-foundation.org: fix arm]
[akpm@linux-foundation.org: fix mips]
[akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c]
[akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c]
[akpm@linux-foundation.org: fix powerpc]
Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
Cc: <linux-arch@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-24 10:47:21 -07:00
..
chips [MTD][NOR] Add physical address to point() method 2008-05-01 18:59:11 +01:00
devices MTD: handle pci_name() being const 2008-07-21 21:55:03 -07:00
maps PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures 2008-07-24 10:47:21 -07:00
nand Merge branch 'pxa' into devel 2008-07-13 12:05:49 +01:00
onenand [MTD] [MAPS] Fix cmdlineparse handling in mapping files 2008-06-05 07:51:13 +01:00
ubi UBI: cdev lock_kernel() pushdown 2008-06-20 14:03:43 -06:00
Kconfig [MTD] AR7 mtd partition map 2008-04-22 20:48:12 +01:00
Makefile [MTD] AR7 mtd partition map 2008-04-22 20:48:12 +01:00
afs.c
ar7part.c [MTD] Clean up AR7 partition map support 2008-04-23 09:39:49 +01:00
cmdlinepart.c [MTD] cmdlinepart: Missing partition info is not an error 2008-04-22 19:10:15 +01:00
ftl.c pcmcia: remove unused bulkmem.h 2008-06-24 15:33:43 +02:00
inftlcore.c
inftlmount.c [MTD] proper prototypes for inftl_{read,write}_oob() 2008-04-22 15:54:16 +01:00
mtd_blkdevs.c
mtdblock.c
mtdblock_ro.c
mtdchar.c device create: mtd: convert device_create to device_create_drvdata 2008-07-21 21:54:44 -07:00
mtdconcat.c
mtdcore.c [MTD] Unlocking all Intel flash that is locked on power up. 2008-02-03 18:25:16 +11:00
mtdcore.h
mtdoops.c [MTD] mtdoops.c: make struct oops_cxt static again 2008-04-22 12:35:34 +01:00
mtdpart.c [MTD][NOR] Add physical address to point() method 2008-05-01 18:59:11 +01:00
mtdsuper.c Introduce path_put() 2008-02-14 21:13:33 -08:00
nftlcore.c
nftlmount.c [MTD] proper prototypes for nftl_{read,write}_oob() 2008-04-22 15:54:29 +01:00
ofpart.c [MTD] mtd/ofpart.c: add MODULE_LICENSE 2008-04-22 15:53:52 +01:00
redboot.c Fix various old email addresses for dwmw2 2008-06-06 11:29:10 -07:00
rfd_ftl.c [MTD] make struct rfd_ftl_tr static 2008-04-22 15:59:25 +01:00
ssfdc.c