740ad921f8
This patch patch eliminates potential AB-BA deadlock when one process calls
open(), or VIDIOC_S/TRY_FMT ioctl on the FIMC capture video node, while
other thread is reconfiguring media links via media device node:
/dev/video? open() /dev/media? MEDIA_IOC_SETUP_LINK ioctl
mutex_lock(video_lock) mutex_lock(graph_lock)
fimc_pipeline_open() fimc_md_link_notify()
mutex_lock(graph_lock) mutex_lock(video_lock)
... ...
The deadlock is avoided by always taking the graph mutex first in video
node open() or an ioctl, before the video lock is acquired. Reversed
order seems impossible, since media device driver's link_notify callback
is called with media graph mutex already held.
To ensure proper locking order VIDIOC_S_FMT and VIDIOC_TRY_FMT ioctls are
not serialized in the v4l2-core and the driver takes care of it itself.
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
|
||
|---|---|---|
| .. | ||
| blackfin | ||
| davinci | ||
| exynos-gsc | ||
| marvell-ccic | ||
| omap | ||
| omap3isp | ||
| s3c-camif | ||
| s5p-fimc | ||
| s5p-g2d | ||
| s5p-jpeg | ||
| s5p-mfc | ||
| s5p-tv | ||
| soc_camera | ||
| Kconfig | ||
| Makefile | ||
| arv.c | ||
| coda.c | ||
| coda.h | ||
| fsl-viu.c | ||
| indycam.c | ||
| indycam.h | ||
| m2m-deinterlace.c | ||
| mem2mem_testdev.c | ||
| mx2_emmaprp.c | ||
| omap24xxcam-dma.c | ||
| omap24xxcam.c | ||
| omap24xxcam.h | ||
| sh_veu.c | ||
| sh_vou.c | ||
| timblogiw.c | ||
| via-camera.c | ||
| via-camera.h | ||
| vino.c | ||
| vino.h | ||
| vivi.c | ||