linux/drivers/video/aty
David S. Miller 7ab876703d [RADEON]: Fix blanking return value.
If you'll recall, over a year ago, I pointed out that the current
Radeon driver erroneously returns -EINVAL for valid blanking codes,
here is a link to that thread:

	http://lkml.org/lkml/2006/1/28/6

No other driver does this, and it confuses the X server into thinking
that the device does not support blanking properly.

I looked again and there is simply no reason for the Radeon driver to
return -EINVAL for FB_BLANK_NORMAL.  It claims it wants to do this in
order to convince fbcon to blank in software, right here:

			if (fb_blank(info, blank))
				fbcon_generic_blank(vc, info, blank);

to software blank the screen.  But it only causes that to happen
in the FB_BLANK_NORMAL case.

That makes no sense because the Radeon code does this:

		val |= CRTC_DISPLAY_DIS;

in the FB_BLANK_NORMAL case so should be blanking the hardware, and
there is therefore no reason to SW blank by returning -EINVAL.

Signed-off-by: David S. Miller <davem@davemloft.net>
Acked-by: Antonino Daplas <adaplas@gmail.com>
2007-03-02 15:22:54 -08:00
..
Makefile
ati_ids.h
aty128fb.c backlight: Separate backlight properties from backlight ops pointers 2007-02-20 09:26:53 +00:00
atyfb.h [PATCH] atyfb: Improve power management 2006-12-08 08:29:07 -08:00
atyfb_base.c backlight: Separate backlight properties from backlight ops pointers 2007-02-20 09:26:53 +00:00
mach64_accel.c [PATCH] remove many unneeded #includes of sched.h 2007-02-14 08:09:54 -08:00
mach64_ct.c [PATCH] atyfb: Improve power management 2006-12-08 08:29:07 -08:00
mach64_cursor.c [PATCH] atyfb: Fix section warnings 2006-06-26 09:58:31 -07:00
mach64_gx.c [PATCH] remove many unneeded #includes of sched.h 2007-02-14 08:09:54 -08:00
radeon_accel.c
radeon_backlight.c backlight: Separate backlight properties from backlight ops pointers 2007-02-20 09:26:53 +00:00
radeon_base.c [RADEON]: Fix blanking return value. 2007-03-02 15:22:54 -08:00
radeon_i2c.c [PATCH] remove many unneeded #includes of sched.h 2007-02-14 08:09:54 -08:00
radeon_monitor.c [PATCH] drivers/video/*: use kmemdup() 2006-12-08 08:29:07 -08:00
radeon_pm.c [PATCH] radeonfb supend/resume support for Acer Aspire 2010 2006-10-03 08:04:13 -07:00
radeonfb.h [PATCH] radeonfb sleep fixes 2006-07-31 13:28:45 -07:00