linux/drivers/hwmon
Henrik Rydberg 25f2bd7f5a hwmon: (applesmc) Always read until end of data
The crash reported and investigated in commit 5f4513 turned out to be
caused by a change to the read interface on newer (2012) SMCs.

Tests by Chris show that simply reading the data valid line is enough
for the problem to go away. Additional tests show that the newer SMCs
no longer wait for the number of requested bytes, but start sending
data right away.  Apparently the number of bytes to read is no longer
specified as before, but instead found out by reading until end of
data. Failure to read until end of data confuses the state machine,
which eventually causes the crash.

As a remedy, assuming bit0 is the read valid line, make sure there is
nothing more to read before leaving the read function.

Tested to resolve the original problem, and runtested on MBA3,1,
MBP4,1, MBP8,2, MBP10,1, MBP10,2. The patch seems to have no effect on
machines before 2012.

Tested-by: Chris Murphy <chris@cmurf.com>
Cc: stable@vger.kernel.org
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
2013-10-09 09:48:55 -07:00
..
pmbus hwmon: use dev_get_platdata() 2013-08-11 22:10:39 -07:00
Kconfig hwmon: (htu21) Add Measurement Specialties HTU21D support 2013-08-29 09:09:12 -07:00
Makefile hwmon: (htu21) Add Measurement Specialties HTU21D support 2013-08-29 09:09:12 -07:00
ab8500.c hwmon: Add ST-Ericsson ABX500 hwmon driver 2013-04-16 18:27:52 -07:00
abituguru.c hwmon: fix error return code in abituguru_probe() 2013-05-13 08:07:13 -07:00
abituguru3.c hwmon: (abituguru3) Remove redundant platform_set_drvdata() 2013-06-21 10:05:03 -07:00
abx500.c hwmon: (abx500) Staticize abx500_temp_attributes 2013-07-14 16:24:25 -07:00
abx500.h hwmon: Add ST-Ericsson ABX500 hwmon driver 2013-04-16 18:27:52 -07:00
acpi_power_meter.c hwmon: Change my email address. 2013-08-27 08:28:01 -07:00
ad7314.c hwmon: (ad7314) use spi_get_drvdata() and spi_set_drvdata() 2013-04-07 21:16:42 -07:00
ad7414.c hwmon: Replace SENSORS_LIMIT with clamp_val 2013-01-25 21:03:54 -08:00
ad7418.c hwmon: (ad7418) Convert to use devm_ functions 2012-09-23 21:08:29 -07:00
adcxx.c hwmon: remove use of __devexit 2012-11-28 11:50:34 -08:00
adm1021.c hwmon: (adm1021) Do not create min sysfs attributes for LM84 2013-06-27 10:29:02 -07:00
adm1025.c hwmon: (adm1025) Convert to use devm_ functions 2012-07-21 21:48:38 -07:00
adm1026.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
adm1029.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
adm1031.c hwmon: Replace SENSORS_LIMIT with clamp_val 2013-01-25 21:03:54 -08:00
adm9240.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
ads1015.c hwmon: (ads1015) Add support for ADS1115 2013-08-11 22:10:40 -07:00
ads7828.c hwmon: use dev_get_platdata() 2013-08-11 22:10:39 -07:00
ads7871.c hwmon: Fix CamelCase checkpatch warnings 2013-04-07 21:16:40 -07:00
adt7x10.c hwmon: (adt7x10) Add alarm interrupt support 2013-04-07 21:16:38 -07:00
adt7x10.h hwmon: (adt7x10) Add alarm interrupt support 2013-04-07 21:16:38 -07:00
adt7310.c hwmon: (adt7310) Fix sparse warning 2013-04-07 21:16:41 -07:00
adt7410.c hwmon: (adt7x10) Add alarm interrupt support 2013-04-07 21:16:38 -07:00
adt7411.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
adt7462.c hwmon: Change my email address. 2013-08-27 08:28:01 -07:00
adt7470.c hwmon: Change my email address. 2013-08-27 08:28:01 -07:00
adt7475.c hwmon: Replace SENSORS_LIMIT with clamp_val 2013-01-25 21:03:54 -08:00
amc6821.c hwmon: (amc6821) Remove redundant break 2013-09-11 13:01:40 -07:00
applesmc.c hwmon: (applesmc) Always read until end of data 2013-10-09 09:48:55 -07:00
asb100.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
asc7621.c hwmon: Fix CamelCase checkpatch warnings 2013-04-07 21:16:40 -07:00
asus_atk0110.c ACPI: Remove useless type argument of driver .remove() operation 2013-01-26 00:37:24 +01:00
atxp1.c hwmon: (atxp1) Convert to use devm_ functions 2012-07-21 21:48:39 -07:00
coretemp.c hwmon: (coretemp) Atom CPUs don't support TjMax; no warning needed 2013-08-11 22:10:38 -07:00
da9052-hwmon.c hwmon: Fix CamelCase checkpatch warnings 2013-04-07 21:16:40 -07:00
da9055-hwmon.c hwmon: Fix CamelCase checkpatch warnings 2013-04-07 21:16:40 -07:00
dme1737.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
ds620.c hwmon: use dev_get_platdata() 2013-08-11 22:10:39 -07:00
ds1621.c hwmon: (ds1621) Fix temperature rounding operations 2013-06-28 06:43:55 -07:00
emc6w201.c hwmon: (emc6w201) Do not declare enum variable 2013-09-06 14:05:43 +02:00
emc1403.c hwmon: Add missing inclusions of <linux/jiffies.h> 2012-10-10 15:25:56 +02:00
emc2103.c hwmon: (emc2103) Fix return value 2013-09-11 13:01:31 -07:00
f71805f.c hwmon: use dev_get_platdata() 2013-08-11 22:10:39 -07:00
f71882fg.c hwmon: use dev_get_platdata() 2013-08-11 22:10:39 -07:00
f75375s.c hwmon: use dev_get_platdata() 2013-08-11 22:10:39 -07:00
fam15h_power.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
fschmd.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
g760a.c hwmon: Replace SENSORS_LIMIT with clamp_val 2013-01-25 21:03:54 -08:00
g762.c hwmon: use dev_get_platdata() 2013-08-11 22:10:39 -07:00
gl518sm.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
gl520sm.c hwmon: Replace SENSORS_LIMIT with clamp_val 2013-01-25 21:03:54 -08:00
gpio-fan.c hwmon: use dev_get_platdata() 2013-08-11 22:10:39 -07:00
hih6130.c hwmon: remove use of __devexit 2012-11-28 11:50:34 -08:00
htu21.c hwmon: (htu21) Add Measurement Specialties HTU21D support 2013-08-29 09:09:12 -07:00
hwmon-vid.c hwmon: (hwmon-vid) Add __maybe_unused attribute to dummy variable 2013-09-10 06:28:17 -07:00
hwmon.c hwmon: Fix PCI device reference leak in quirk 2012-12-19 22:16:59 +01:00
i5k_amb.c hwmon: Change my email address. 2013-08-27 08:28:01 -07:00
ibmaem.c hwmon: (ibmaem) Fix return value 2013-09-11 13:01:32 -07:00
ibmpex.c hwmon: Change my email address. 2013-08-27 08:28:01 -07:00
iio_hwmon.c hwmon: (iio_hwmon) add alias table 2013-06-27 10:29:03 -07:00
ina2xx.c hwmon: (ina2xx) Remove casting the return value which is a void pointer 2013-09-10 06:28:31 -07:00
ina209.c hwmon: Driver for Texas Instruments INA209 2013-02-06 09:57:59 -08:00
it87.c hwmon: use dev_get_platdata() 2013-08-11 22:10:39 -07:00
jc42.c hwmon: (jc42) Add support for MCP98244 2013-02-06 09:58:07 -08:00
jz4740-hwmon.c hwmon: remove use of __devexit 2012-11-28 11:50:34 -08:00
k8temp.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
k10temp.c hwmon: (k10temp) remove unnecessary pci_set_drvdata() 2013-09-12 08:17:40 -07:00
lineage-pem.c hwmon: (lineage-pem) Add missing terminating entry for pem_[input|fan]_attributes 2013-03-14 06:55:21 -07:00
lm63.c hwmon: (lm63) Drop redundant safety on cache lifetime 2013-07-08 14:18:24 +02:00
lm70.c hwmon: remove use of __devexit 2012-11-28 11:50:34 -08:00
lm73.c hwmon: (lm73) Add support for max/min alarms 2013-02-06 09:57:58 -08:00
lm75.c hwmon: (lm75) Add support for the Dallas/Maxim DS7505 2013-05-04 14:49:36 +02:00
lm75.h hwmon: (lm75.h) Update header inclusion 2013-03-18 21:19:49 +01:00
lm77.c hwmon: Replace SENSORS_LIMIT with clamp_val 2013-01-25 21:03:54 -08:00
lm78.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
lm80.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
lm83.c hwmon: (lm83) Convert to use devm_ functions 2012-07-21 21:48:38 -07:00
lm85.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
lm87.c hwmon: use dev_get_platdata() 2013-08-11 22:10:39 -07:00
lm90.c hwmon: (lm90) Drop redundant safety on cache lifetime 2013-07-08 14:18:24 +02:00
lm92.c hwmon: Add missing inclusions of <linux/jiffies.h> 2012-10-10 15:25:56 +02:00
lm93.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
lm95234.c hwmon: Add driver for LM95234 2013-04-07 21:16:42 -07:00
lm95241.c hwmon: (lm95241) Convert to use devm_ functions 2012-09-23 21:08:31 -07:00
lm95245.c hwmon: Replace SENSORS_LIMIT with clamp_val 2013-01-25 21:03:54 -08:00
ltc4151.c hwmon: (ltc4151) Fix 'Avoid unnecessary line continuations' checkpatch warning 2013-04-07 21:16:40 -07:00
ltc4215.c hwmon: (ltc4215) Fix 'Macros with complex values' checkpatch error 2013-04-07 21:16:40 -07:00
ltc4245.c hwmon: (ltc4245) Fix 'Macros with complex values' checkpatch error 2013-04-07 21:16:40 -07:00
ltc4261.c hwmon: (ltc4261) Fix 'Macros with complex values' checkpatch error 2013-04-07 21:16:40 -07:00
max197.c hwmon: use dev_get_platdata() 2013-08-11 22:10:39 -07:00
max1111.c hwmon: remove use of __devexit 2012-11-28 11:50:34 -08:00
max1619.c hwmon: Update Alexey Fisher's name 2012-10-10 15:25:56 +02:00
max1668.c hwmon: Replace SENSORS_LIMIT with clamp_val 2013-01-25 21:03:54 -08:00
max6639.c hwmon: use dev_get_platdata() 2013-08-11 22:10:39 -07:00
max6642.c hwmon: Replace SENSORS_LIMIT with clamp_val 2013-01-25 21:03:54 -08:00
max6650.c hwmon: Replace SENSORS_LIMIT with clamp_val 2013-01-25 21:03:54 -08:00
max6697.c hwmon: (max6697) fix MAX6581 ideality 2013-08-03 07:04:50 -07:00
max16065.c hwmon: Replace SENSORS_LIMIT with clamp_val 2013-01-25 21:03:54 -08:00
mc13783-adc.c hwmon: (mc13783-adc.c) use module_platform_driver_probe() 2013-04-07 21:16:37 -07:00
mcp3021.c hwmon: use dev_get_platdata() 2013-08-11 22:10:39 -07:00
nct6775.c hwmon: (nct6775) Add support for hibernate 2013-08-11 22:10:39 -07:00
ntc_thermistor.c hwmon: use dev_get_platdata() 2013-08-11 22:10:39 -07:00
pc87360.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
pc87427.c hwmon: use dev_get_platdata() 2013-08-11 22:10:39 -07:00
pcf8591.c hwmon: (pcf8591) Convert to use devm_ functions 2012-07-21 21:48:41 -07:00
s3c-hwmon.c hwmon: use dev_get_platdata() 2013-08-11 22:10:39 -07:00
sch56xx-common.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
sch56xx-common.h watchdog: sch56xx: Use watchdog core 2012-05-30 07:55:38 +02:00
sch5627.c hwmon: remove use of __devinit 2012-11-28 11:49:40 -08:00
sch5636.c hwmon: remove use of __devinit 2012-11-28 11:49:40 -08:00
sht15.c New driver for HTU21D (humidity sensor) 2013-09-03 10:43:35 -07:00
sht21.c hwmon: remove use of __devexit 2012-11-28 11:50:34 -08:00
sis5595.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
smm665.c hwmon: Add missing inclusions of <linux/jiffies.h> 2012-10-10 15:25:56 +02:00
smsc47b397.c hwmon: remove use of __devexit 2012-11-28 11:50:34 -08:00
smsc47m1.c hwmon: use dev_get_platdata() 2013-08-11 22:10:39 -07:00
smsc47m192.c hwmon: Replace SENSORS_LIMIT with clamp_val 2013-01-25 21:03:54 -08:00
thmc50.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
tmp102.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
tmp401.c hwmon: (tmp401) Drop redundant safety on cache lifetime 2013-05-19 08:19:29 -07:00
tmp421.c hwmon: (tmp421) Fix return value 2013-09-11 13:01:41 -07:00
twl4030-madc-hwmon.c hwmon: (twl4030-madc-hwmon) Fix warning message caused by removal of __devexit 2012-12-16 18:21:33 -08:00
ultra45_env.c hwmon: remove use of __devexit 2012-11-28 11:50:34 -08:00
vexpress.c hwmon: (vexpress) Fix build error seen if CONFIG_OF_DEVICE is not set 2013-01-09 21:47:22 -08:00
via-cputemp.c hwmon: delete __cpuinit usage from all hwmon files 2013-07-14 19:36:57 -04:00
via686a.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
vt1211.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
vt8231.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
w83l785ts.c hwmon: (w83l785ts) Convert to use devm_ functions 2012-07-21 21:48:43 -07:00
w83l786ng.c hwmon: Replace SENSORS_LIMIT with clamp_val 2013-01-25 21:03:54 -08:00
w83627ehf.c hwmon: (w83627ehf) Add support for hibernate 2013-08-11 22:10:40 -07:00
w83627hf.c hwmon: use dev_get_platdata() 2013-08-11 22:10:39 -07:00
w83781d.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
w83791d.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
w83792d.c hwmon: (w83792d) Update module author 2013-09-06 14:05:42 +02:00
w83793.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
w83795.c hwmon: Fix checkpatch warning 'quoted string split across lines' 2013-04-07 21:16:40 -07:00
wm831x-hwmon.c hwmon: remove use of __devexit 2012-11-28 11:50:34 -08:00
wm8350-hwmon.c hwmon: remove use of __devexit 2012-11-28 11:50:34 -08:00