b9bdcd9bd7
with while (--worklimit >= 0); worklimit reaches -1 after the loop. In
3c589_cs.c this caused a warning not to be printed.
In 3c574_cs.c contrastingly, el3_rx() treats worklimit differently:
static int el3_rx(struct net_device *dev, int worklimit)
{
while (--worklimit >= 0) { ... }
return worklimit;
}
el3_rx() is only called by function el3_interrupt(): twice:
static irqreturn_t el3_interrupt(int irq, void *dev_id)
{
int work_budget = max_interrupt_work;
while(...) {
if (...)
work_budget = el3_rx(dev, work_budget);
if (...)
work_budget = el3_rx(dev, work_budget);
if (--work_budget < 0) {
...
break;
}
}
}
The error path can occur 2 too early.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
|
||
|---|---|---|
| .. | ||
| 3c574_cs.c | ||
| 3c589_cs.c | ||
| Kconfig | ||
| Makefile | ||
| axnet_cs.c | ||
| com20020_cs.c | ||
| fmvj18x_cs.c | ||
| ibmtr_cs.c | ||
| nmclan_cs.c | ||
| ositech.h | ||
| pcnet_cs.c | ||
| smc91c92_cs.c | ||
| xirc2ps_cs.c | ||